Convert over to channel handles

Convert over to channel handles

This hides some of the internals of the posix channels from users, and gets rid
of several #ifdef POSIX blocks. Generally simplifies usage of channels xplatform.

BUG=none
TEST=build

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68621

[dmac, 2010-12-08 01:26:57]

Sorry for the size, but couldn't think of any better way to partition this up.

[agl, 2010-12-08 15:38:57]

It's been some time since I really knew what was going on with the IPC stuff,
but there appears to be more red than green, so LGTM.

http://codereview.chromium.org/5598010/diff/2001/ipc/ipc_channel_handle.h
File ipc/ipc_channel_handle.h (right):

http://codereview.chromium.org/5598010/diff/2001/ipc/ipc_channel_handle.h#new...
ipc/ipc_channel_handle.h:37: ChannelHandle() {}
Constructors are typically first in a class/struct

http://codereview.chromium.org/5598010/diff/2001/ipc/ipc_channel_proxy.cc
File ipc/ipc_channel_proxy.cc (right):

http://codereview.chromium.org/5598010/diff/2001/ipc/ipc_channel_proxy.cc#new...
ipc/ipc_channel_proxy.cc:304: // When we are creating a server on POSIX, we need
it's file descriptor
s/it's/its/

http://codereview.chromium.org/5598010/diff/2001/ipc/ipc_channel_proxy.cc#new...
ipc/ipc_channel_proxy.cc:306: // to other processes. Forcing it to be made
immediately avoids
s/made/created/

[brettw, 2010-12-08 22:49:27]

Style nits.

http://codereview.chromium.org/5598010/diff/2001/ipc/ipc_channel.h
File ipc/ipc_channel.h (right):

http://codereview.chromium.org/5598010/diff/2001/ipc/ipc_channel.h#newcode69
ipc/ipc_channel.h:69: Channel(const IPC::ChannelHandle &channel_handle, Mode
mode,
The & should be next to the type name.

http://codereview.chromium.org/5598010/diff/2001/ipc/ipc_channel_posix.h
File ipc/ipc_channel_posix.h (right):

http://codereview.chromium.org/5598010/diff/2001/ipc/ipc_channel_posix.h#newc...
ipc/ipc_channel_posix.h:27: ChannelImpl(const IPC::ChannelHandle
&channel_handle, Mode mode,
Be sure to check these other places as well.