Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/gpu/gpu_channel.h

Issue 5598010: Convert over to channel handles (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixed up bad whitespace Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/gpu/gpu_channel.h
diff --git a/chrome/gpu/gpu_channel.h b/chrome/gpu/gpu_channel.h
index 3d64355cf3386907383ba820e119b26afb5d849d..53c0d7029e3ee0df1a2375177fb59eca8b5e7e3b 100644
--- a/chrome/gpu/gpu_channel.h
+++ b/chrome/gpu/gpu_channel.h
@@ -36,22 +36,14 @@ class GpuChannel : public IPC::Channel::Listener,
std::string GetChannelName();
+#if defined(OS_POSIX)
+ int GetRendererFileDescriptor();
+#endif // defined(OS_POSIX)
+
base::ProcessHandle renderer_handle() const {
return renderer_process_.handle();
}
-#if defined(OS_POSIX)
- // When first created, the GpuChannel gets assigned the file descriptor
- // for the renderer.
- // After the first time we pass it through the IPC, we don't need it anymore,
- // and we close it. At that time, we reset renderer_fd_ to -1.
- int DisownRendererFd() {
- int value = renderer_fd_;
- renderer_fd_ = -1;
- return value;
- }
-#endif
-
// IPC::Channel::Listener implementation:
virtual void OnMessageReceived(const IPC::Message& msg);
virtual void OnChannelConnected(int32 peer_pid);
@@ -96,12 +88,6 @@ class GpuChannel : public IPC::Channel::Listener,
// The id of the renderer who is on the other side of the channel.
int renderer_id_;
-#if defined(OS_POSIX)
- // FD for the renderer end of the pipe. It is stored until we send it over
- // IPC after which it is cleared. It will be closed by the IPC mechanism.
- int renderer_fd_;
-#endif
-
// Used to implement message routing functionality to CommandBuffer objects
MessageRouter router_;

Powered by Google App Engine
This is Rietveld 408576698