Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3942)

Unified Diff: chrome/plugin/plugin_channel.h

Issue 5598010: Convert over to channel handles (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixed up bad whitespace Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/plugin/plugin_channel.h
diff --git a/chrome/plugin/plugin_channel.h b/chrome/plugin/plugin_channel.h
index cc444c054cafa4145a9660cd838ad08e75364182..0412b40135e9a946fae9cfaa269eacf10f95c471 100644
--- a/chrome/plugin/plugin_channel.h
+++ b/chrome/plugin/plugin_channel.h
@@ -50,7 +50,7 @@ class PluginChannel : public PluginChannelBase {
void set_off_the_record(bool value) { off_the_record_ = value; }
#if defined(OS_POSIX)
- int renderer_fd() const { return renderer_fd_; }
+ int renderer_fd() const { return channel_->GetClientFileDescriptor(); }
#endif
protected:
@@ -80,13 +80,6 @@ class PluginChannel : public PluginChannelBase {
const std::string& domain,
base::Time begin_time);
-#if defined(OS_POSIX)
- // Close the plugin process' copy of the renderer's side of the plugin
- // channel. This can be called after the renderer is known to have its own
- // copy of renderer_fd_.
- void CloseRendererFD();
-#endif
-
std::vector<scoped_refptr<WebPluginDelegateStub> > plugin_stubs_;
// Handle to the renderer process who is on the other side of the channel.
@@ -95,13 +88,6 @@ class PluginChannel : public PluginChannelBase {
// The id of the renderer who is on the other side of the channel.
int renderer_id_;
-#if defined(OS_POSIX)
- // FD for the renderer end of the socket. It is closed when the IPC layer
- // indicates that the channel is connected, proving that the renderer has
- // access to its side of the socket.
- int renderer_fd_;
-#endif
-
int in_send_; // Tracks if we're in a Send call.
bool log_messages_; // True if we should log sent and received messages.
bool off_the_record_; // True if the renderer is in off the record mode.
« no previous file with comments | « chrome/gpu/gpu_thread.cc ('k') | chrome/plugin/plugin_channel.cc » ('j') | ipc/ipc_channel.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698