Issue 555048: Make KeyedLoadIC::generic_stub go into slow case if receiver has an indexed i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 555048: Make KeyedLoadIC::generic_stub go into slow case if receiver has an indexed i... (Closed)

Created:
10 years, 11 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make KeyedLoadIC::generic_stub go into slow case if receiver has an indexed interceptor. BUG=589, 27967 . Committed: http://code.google.com/p/v8/source/detail?r=3680

Patch Set 2 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -33 lines)			Patch
M	src/arm/ic-arm.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/ic.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/x64/ic-x64.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	test/cctest/test-api.cc	View		3 chunks	+51 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

Ideally there should be a special stub for indexed interceptors, going to file a bug.

10 years, 11 months ago (2010-01-22 11:20:50 UTC) #1

Mads Ager (chromium)

LGTM! Well spotted Anton! http://codereview.chromium.org/555048/diff/1/4 File src/ic.h (right): http://codereview.chromium.org/555048/diff/1/4#newcode304 src/ic.h:304: (1 << Map::kHasIndexedInterceptor); I think ...

10 years, 11 months ago (2010-01-22 12:18:53 UTC) #2