Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: src/arm/ic-arm.cc

Issue 555048: Make KeyedLoadIC::generic_stub go into slow case if receiver has an indexed i... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 551 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 // Check that the key is a smi. 562 // Check that the key is a smi.
563 __ tst(r0, Operand(kSmiTagMask)); 563 __ tst(r0, Operand(kSmiTagMask));
564 __ b(ne, &slow); 564 __ b(ne, &slow);
565 __ mov(r0, Operand(r0, ASR, kSmiTagSize)); 565 __ mov(r0, Operand(r0, ASR, kSmiTagSize));
566 // Check that the object isn't a smi. 566 // Check that the object isn't a smi.
567 __ tst(r1, Operand(kSmiTagMask)); 567 __ tst(r1, Operand(kSmiTagMask));
568 __ b(eq, &slow); 568 __ b(eq, &slow);
569 569
570 // Get the map of the receiver. 570 // Get the map of the receiver.
571 __ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset)); 571 __ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset));
572 // Check that the receiver does not require access checks. We need 572
573 // to check this explicitly since this generic stub does not perform 573 // Check bit field.
574 // map checks.
575 __ ldrb(r3, FieldMemOperand(r2, Map::kBitFieldOffset)); 574 __ ldrb(r3, FieldMemOperand(r2, Map::kBitFieldOffset));
576 __ tst(r3, Operand(1 << Map::kIsAccessCheckNeeded)); 575 __ tst(r3, Operand(kSlowCaseBitFieldMask));
577 __ b(ne, &slow); 576 __ b(ne, &slow);
578 // Check that the object is some kind of JS object EXCEPT JS Value type. 577 // Check that the object is some kind of JS object EXCEPT JS Value type.
579 // In the case that the object is a value-wrapper object, 578 // In the case that the object is a value-wrapper object,
580 // we enter the runtime system to make sure that indexing into string 579 // we enter the runtime system to make sure that indexing into string
581 // objects work as intended. 580 // objects work as intended.
582 ASSERT(JS_OBJECT_TYPE > JS_VALUE_TYPE); 581 ASSERT(JS_OBJECT_TYPE > JS_VALUE_TYPE);
583 __ ldrb(r2, FieldMemOperand(r2, Map::kInstanceTypeOffset)); 582 __ ldrb(r2, FieldMemOperand(r2, Map::kInstanceTypeOffset));
584 __ cmp(r2, Operand(JS_OBJECT_TYPE)); 583 __ cmp(r2, Operand(JS_OBJECT_TYPE));
585 __ b(lt, &slow); 584 __ b(lt, &slow);
586 585
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
841 840
842 // Perform tail call to the entry. 841 // Perform tail call to the entry.
843 __ TailCallRuntime(f, 3, 1); 842 __ TailCallRuntime(f, 3, 1);
844 } 843 }
845 844
846 845
847 #undef __ 846 #undef __
848 847
849 848
850 } } // namespace v8::internal 849 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698