src/x64/ic-x64.cc - Issue 555048: Make KeyedLoadIC::generic_stub go into slow case if receiver has an indexed i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/ic-x64.cc

Issue 555048: Make KeyedLoadIC::generic_stub go into slow case if receiver has an indexed i... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/ic-x64.cc

===================================================================

--- src/x64/ic-x64.cc (revision 3678)

+++ src/x64/ic-x64.cc (working copy)

@@ -271,11 +271,10 @@

ASSERT(JS_OBJECT_TYPE > JS_VALUE_TYPE);

__ CmpObjectType(rcx, JS_OBJECT_TYPE, rdx);

__ j(below, &slow);

- // Check that the receiver does not require access checks. We need

- // to check this explicitly since this generic stub does not perform

- // map checks. The map is already in rdx.

+ // Check bit field.

__ testb(FieldOperand(rdx, Map::kBitFieldOffset),

- Immediate(1 << Map::kIsAccessCheckNeeded));

+ Immediate(kSlowCaseBitFieldMask));

__ j(not_zero, &slow);

// Check that the key is a smi.

« no previous file with comments | « src/ic.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »