Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 555048: Make KeyedLoadIC::generic_stub go into slow case if receiver has an indexed i... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 // Load name and receiver. 237 // Load name and receiver.
238 __ mov(eax, Operand(esp, kPointerSize)); 238 __ mov(eax, Operand(esp, kPointerSize));
239 __ mov(ecx, Operand(esp, 2 * kPointerSize)); 239 __ mov(ecx, Operand(esp, 2 * kPointerSize));
240 240
241 // Check that the object isn't a smi. 241 // Check that the object isn't a smi.
242 __ test(ecx, Immediate(kSmiTagMask)); 242 __ test(ecx, Immediate(kSmiTagMask));
243 __ j(zero, &slow, not_taken); 243 __ j(zero, &slow, not_taken);
244 244
245 // Get the map of the receiver. 245 // Get the map of the receiver.
246 __ mov(edx, FieldOperand(ecx, HeapObject::kMapOffset)); 246 __ mov(edx, FieldOperand(ecx, HeapObject::kMapOffset));
247 // Check that the receiver does not require access checks. We need 247
248 // to check this explicitly since this generic stub does not perform 248 // Check bit field.
249 // map checks.
250 __ movzx_b(ebx, FieldOperand(edx, Map::kBitFieldOffset)); 249 __ movzx_b(ebx, FieldOperand(edx, Map::kBitFieldOffset));
251 __ test(ebx, Immediate(1 << Map::kIsAccessCheckNeeded)); 250 __ test(ebx, Immediate(kSlowCaseBitFieldMask));
252 __ j(not_zero, &slow, not_taken); 251 __ j(not_zero, &slow, not_taken);
253 // Check that the object is some kind of JS object EXCEPT JS Value type. 252 // Check that the object is some kind of JS object EXCEPT JS Value type.
254 // In the case that the object is a value-wrapper object, 253 // In the case that the object is a value-wrapper object,
255 // we enter the runtime system to make sure that indexing 254 // we enter the runtime system to make sure that indexing
256 // into string objects work as intended. 255 // into string objects work as intended.
257 ASSERT(JS_OBJECT_TYPE > JS_VALUE_TYPE); 256 ASSERT(JS_OBJECT_TYPE > JS_VALUE_TYPE);
258 __ movzx_b(edx, FieldOperand(edx, Map::kInstanceTypeOffset)); 257 __ movzx_b(edx, FieldOperand(edx, Map::kInstanceTypeOffset));
259 __ cmp(edx, JS_OBJECT_TYPE); 258 __ cmp(edx, JS_OBJECT_TYPE);
260 __ j(less, &slow, not_taken); 259 __ j(less, &slow, not_taken);
261 // Check that the key is a smi. 260 // Check that the key is a smi.
(...skipping 1220 matching lines...) Expand 10 before | Expand all | Expand 10 after
1482 1481
1483 // Do tail-call to runtime routine. 1482 // Do tail-call to runtime routine.
1484 __ TailCallRuntime( 1483 __ TailCallRuntime(
1485 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3, 1); 1484 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3, 1);
1486 } 1485 }
1487 1486
1488 #undef __ 1487 #undef __
1489 1488
1490 1489
1491 } } // namespace v8::internal 1490 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698