Implements glGetVertexAttribPointerv

Implements glGetVertexAttribPointerv

TEST=none
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37496

[apatrick, 2010-01-29 02:43:57]

lgtm

http://codereview.chromium.org/549201/diff/1/8
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

http://codereview.chromium.org/549201/diff/1/8#newcode1347
gpu/command_buffer/build_gles2_cmd_buffer.py:1347: #def
WriteGLES2ImplementationImpl(self, func, file):
Delete these commented out code blocks?

http://codereview.chromium.org/549201/diff/1/6
File gpu/command_buffer/client/gles2_implementation.cc (right):

http://codereview.chromium.org/549201/diff/1/6#newcode285
gpu/command_buffer/client/gles2_implementation.cc:285: // TODO(gman): implement.
you could put NOTREACHED() in these so it asserts.

http://codereview.chromium.org/549201/diff/1/4
File gpu/command_buffer/common/gles2_cmd_format.h (right):

http://codereview.chromium.org/549201/diff/1/4#newcode41
gpu/command_buffer/common/gles2_cmd_format.h:41: void* data;  // this is just
here to get an offset.
I would make this a non-pointer type. Otherwise it seems like data points to the
data. int32?

http://codereview.chromium.org/549201/diff/1/2
File gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc (right):

http://codereview.chromium.org/549201/diff/1/2#newcode694
gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc:694: const GLuint
kOffsetToTestFor = 16u;  // 4 floats in
sizeof(float) * 4
?

[greggman, 2010-02-02 02:31:03]

http://codereview.chromium.org/549201/diff/1/8
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

http://codereview.chromium.org/549201/diff/1/8#newcode1347
gpu/command_buffer/build_gles2_cmd_buffer.py:1347: #def
WriteGLES2ImplementationImpl(self, func, file):
On 2010/01/29 02:43:57, apatrick wrote:
> Delete these commented out code blocks?

Done.

http://codereview.chromium.org/549201/diff/1/6
File gpu/command_buffer/client/gles2_implementation.cc (right):

http://codereview.chromium.org/549201/diff/1/6#newcode285
gpu/command_buffer/client/gles2_implementation.cc:285: // TODO(gman): implement.
On 2010/01/29 02:43:57, apatrick wrote:
> you could put NOTREACHED() in these so it asserts.

Done.

http://codereview.chromium.org/549201/diff/1/4
File gpu/command_buffer/common/gles2_cmd_format.h (right):

http://codereview.chromium.org/549201/diff/1/4#newcode41
gpu/command_buffer/common/gles2_cmd_format.h:41: void* data;  // this is just
here to get an offset.
On 2010/01/29 02:43:57, apatrick wrote:
> I would make this a non-pointer type. Otherwise it seems like data points to
the
> data. int32?

Done.

http://codereview.chromium.org/549201/diff/1/2
File gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc (right):

http://codereview.chromium.org/549201/diff/1/2#newcode694
gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc:694: const GLuint
kOffsetToTestFor = 16u;  // 4 floats in
On 2010/01/29 02:43:57, apatrick wrote:
> sizeof(float) * 4
> ?

Done.

[apatrick, 2010-02-02 02:35:26]

lgtm