Issue 543063: Added simple texture demo....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543063: Added simple texture demo.... (Closed)

Created:
10 years, 11 months ago by alokp

Modified:
9 years, 6 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
chromium-reviews_googlegroups.com, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added simple texture demo. BUG=26099 TEST=Run simple_texture_2d executable. You should see a square with checker-board pattern. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36267

Patch Set 1 #

Total comments: 3

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+177 lines, -63 lines)			Patch
M	gpu/demos/demos.gyp	View	1 chunk	+11 lines, -0 lines	0 comments	Download
A	gpu/demos/simple_texture_2d/main.cc	View	1 chunk	+65 lines, -0 lines	3 comments	Download
A	third_party/gles2_book/Chapter_9/Simple_Texture2D/Simple_Texture2D.h	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	third_party/gles2_book/Chapter_9/Simple_Texture2D/Simple_Texture2D.c	View	7 chunks	+41 lines, -63 lines	0 comments	Download
M	third_party/gles2_book/gles2_book.gyp	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apatrick

LGTM http://codereview.chromium.org/543063/diff/1/3 File gpu/demos/simple_texture_2d/main.cc (right): http://codereview.chromium.org/543063/diff/1/3#newcode21 gpu/demos/simple_texture_2d/main.cc:21: virtual void Draw(float); The parameter should be named. ...

10 years, 11 months ago (2010-01-14 19:07:54 UTC) #2

alokp

10 years, 11 months ago (2010-01-14 20:07:29 UTC) #3

http://codereview.chromium.org/543063/diff/1/3
File gpu/demos/simple_texture_2d/main.cc (right):

http://codereview.chromium.org/543063/diff/1/3#newcode21
gpu/demos/simple_texture_2d/main.cc:21: virtual void Draw(float);
This variable is not used for this demo. I did not add the name to prevent the
compiler from complaining about unused variable.

Expand Messages | Collapse Messages