Issue 5305005: Initialize destinations variables before calling GL functions...

Issue 5305005: Initialize destinations variables before calling GL functions... (Closed)

Created:
10 years, 1 month ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
vrk (LEFT CHROMIUM), Zhenyao Mo, apatrick, Nat, apatrick_chromium

CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, ddorwin+watch_chromium.org, Alpha Left Google, apatrick_chromium, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, awong, brettw-cc_chromium.org, darin-cc_chromium.org, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Initialize destinations variables before calling GL functions because if the context is lost those variables will be uninitialized. TEST=ran chrome, conformance tests, unit tests and hand edited gles2_demo to test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67293

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -23 lines)			Patch
M	app/gfx/gl/gl_context.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/gpu/gpu_info_collector_mac.mm	View	1 2	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1	8 chunks	+37 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib.cc	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib_autogen.h	View	1	9 chunks	+22 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_demo_cc.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/common_decoder.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/common_decoder.cc	View		1 chunk	+8 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	media/tools/player_x11/gl_video_renderer.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	media/tools/player_x11/gles_video_renderer.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apatrick

10 years, 1 month ago (2010-11-24 18:13:04 UTC) #3

LGTM when trybots are good.

http://codereview.chromium.org/5305005/diff/1/chrome/gpu/gpu_info_collector_m...
File chrome/gpu/gpu_info_collector_mac.mm (right):

http://codereview.chromium.org/5305005/diff/1/chrome/gpu/gpu_info_collector_m...
chrome/gpu/gpu_info_collector_mac.mm:85: if (gl_extensions_string &&
strstr(gl_extensions_string, "GL_ARB_shading_language_100")) {
Do we do 80 chars in objective C files?

http://codereview.chromium.org/5305005/diff/1/chrome/gpu/gpu_info_collector_m...
chrome/gpu/gpu_info_collector_mac.mm:90: const char *glsl_version_string =
(const char*)glGetString(GL_SHADING_LANGUAGE_VERSION);
Same here if that's the case.

http://codereview.chromium.org/5305005/diff/1/gpu/command_buffer/client/gles2...
File gpu/command_buffer/client/gles2_c_lib.cc (right):

http://codereview.chromium.org/5305005/diff/1/gpu/command_buffer/client/gles2...
gpu/command_buffer/client/gles2_c_lib.cc:18: // Because this is check is not
official GL this check happens only on Chrome
this is check -> this check

Expand Messages | Collapse Messages