chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc - Issue 5305005: Initialize destinations variables before calling GL functions...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc

Issue 5305005: Initialize destinations variables before calling GL functions... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc

===================================================================

--- chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc (revision 67161)

+++ chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc (working copy)

@@ -693,7 +693,7 @@

scoped_array<GLchar> log(new GLchar[logLength]);

if (!log.get())

return WebKit::WebString();

- GLsizei returnedLogLength;

+ GLsizei returnedLogLength = 0;

glGetProgramInfoLog(program, logLength, &returnedLogLength, log.get());

DCHECK_EQ(logLength, returnedLogLength + 1);

WebKit::WebString res =

@@ -716,7 +716,7 @@

scoped_array<GLchar> log(new GLchar[logLength]);

if (!log.get())

return WebKit::WebString();

- GLsizei returnedLogLength;

+ GLsizei returnedLogLength = 0;

glGetShaderInfoLog(shader, logLength, &returnedLogLength, log.get());

DCHECK_EQ(logLength, returnedLogLength + 1);

WebKit::WebString res =

@@ -734,7 +734,7 @@

scoped_array<GLchar> log(new GLchar[logLength]);

if (!log.get())

return WebKit::WebString();

- GLsizei returnedLogLength;

+ GLsizei returnedLogLength = 0;

glGetShaderSource(shader, logLength, &returnedLogLength, log.get());

DCHECK_EQ(logLength, returnedLogLength + 1);

WebKit::WebString res =

« no previous file with comments | « chrome/gpu/gpu_info_collector_mac.mm ('k') | gpu/command_buffer/build_gles2_cmd_buffer.py » ('j') | no next file with comments »