Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4074)

Unified Diff: gpu/command_buffer/client/gles2_c_lib_autogen.h

Issue 5305005: Initialize destinations variables before calling GL functions... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/gles2_c_lib.cc ('k') | gpu/command_buffer/client/gles2_demo_cc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/gles2_c_lib_autogen.h
===================================================================
--- gpu/command_buffer/client/gles2_c_lib_autogen.h (revision 67161)
+++ gpu/command_buffer/client/gles2_c_lib_autogen.h (working copy)
@@ -279,6 +279,9 @@
void GLES2GetActiveAttrib(
GLuint program, GLuint index, GLsizei bufsize, GLsizei* length, GLint* size,
GLenum* type, char* name) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLsizei, length);
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, size);
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLenum, type);
GPU_CLIENT_LOG(
"GetActiveAttrib" << "(" << program << ", " << index << ", " << bufsize << ", " << length << ", " << size << ", " << type << ", " << name << ")"); // NOLINT
gles2::GetGLContext()->GetActiveAttrib(
@@ -287,6 +290,9 @@
void GLES2GetActiveUniform(
GLuint program, GLuint index, GLsizei bufsize, GLsizei* length, GLint* size,
GLenum* type, char* name) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLsizei, length);
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, size);
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLenum, type);
GPU_CLIENT_LOG(
"GetActiveUniform" << "(" << program << ", " << index << ", " << bufsize << ", " << length << ", " << size << ", " << type << ", " << name << ")"); // NOLINT
gles2::GetGLContext()->GetActiveUniform(
@@ -294,6 +300,7 @@
}
void GLES2GetAttachedShaders(
GLuint program, GLsizei maxcount, GLsizei* count, GLuint* shaders) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLsizei, count);
GPU_CLIENT_LOG(
"GetAttachedShaders" << "(" << program << ", " << maxcount << ", " << count << ", " << shaders << ")"); // NOLINT
gles2::GetGLContext()->GetAttachedShaders(program, maxcount, count, shaders);
@@ -305,10 +312,12 @@
return result;
}
void GLES2GetBooleanv(GLenum pname, GLboolean* params) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLboolean, params);
GPU_CLIENT_LOG("GetBooleanv" << "(" << pname << ", " << params << ")");
gles2::GetGLContext()->GetBooleanv(pname, params);
}
void GLES2GetBufferParameteriv(GLenum target, GLenum pname, GLint* params) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
GPU_CLIENT_LOG(
"GetBufferParameteriv" << "(" << target << ", " << pname << ", " << params << ")"); // NOLINT
gles2::GetGLContext()->GetBufferParameteriv(target, pname, params);
@@ -325,45 +334,54 @@
}
void GLES2GetFramebufferAttachmentParameteriv(
GLenum target, GLenum attachment, GLenum pname, GLint* params) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
GPU_CLIENT_LOG(
"GetFramebufferAttachmentParameteriv" << "(" << target << ", " << attachment << ", " << pname << ", " << params << ")"); // NOLINT
gles2::GetGLContext()->GetFramebufferAttachmentParameteriv(
target, attachment, pname, params);
}
void GLES2GetIntegerv(GLenum pname, GLint* params) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
GPU_CLIENT_LOG("GetIntegerv" << "(" << pname << ", " << params << ")");
gles2::GetGLContext()->GetIntegerv(pname, params);
}
void GLES2GetProgramiv(GLuint program, GLenum pname, GLint* params) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
GPU_CLIENT_LOG(
"GetProgramiv" << "(" << program << ", " << pname << ", " << params << ")"); // NOLINT
gles2::GetGLContext()->GetProgramiv(program, pname, params);
}
void GLES2GetProgramInfoLog(
GLuint program, GLsizei bufsize, GLsizei* length, char* infolog) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLsizei, length);
GPU_CLIENT_LOG(
"GetProgramInfoLog" << "(" << program << ", " << bufsize << ", " << length << ", " << infolog << ")"); // NOLINT
gles2::GetGLContext()->GetProgramInfoLog(program, bufsize, length, infolog);
}
void GLES2GetRenderbufferParameteriv(
GLenum target, GLenum pname, GLint* params) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
GPU_CLIENT_LOG(
"GetRenderbufferParameteriv" << "(" << target << ", " << pname << ", " << params << ")"); // NOLINT
gles2::GetGLContext()->GetRenderbufferParameteriv(target, pname, params);
}
void GLES2GetShaderiv(GLuint shader, GLenum pname, GLint* params) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
GPU_CLIENT_LOG(
"GetShaderiv" << "(" << shader << ", " << pname << ", " << params << ")");
gles2::GetGLContext()->GetShaderiv(shader, pname, params);
}
void GLES2GetShaderInfoLog(
GLuint shader, GLsizei bufsize, GLsizei* length, char* infolog) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLsizei, length);
GPU_CLIENT_LOG(
"GetShaderInfoLog" << "(" << shader << ", " << bufsize << ", " << length << ", " << infolog << ")"); // NOLINT
gles2::GetGLContext()->GetShaderInfoLog(shader, bufsize, length, infolog);
}
void GLES2GetShaderPrecisionFormat(
GLenum shadertype, GLenum precisiontype, GLint* range, GLint* precision) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, range);
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, precision);
GPU_CLIENT_LOG(
"GetShaderPrecisionFormat" << "(" << shadertype << ", " << precisiontype << ", " << range << ", " << precision << ")"); // NOLINT
gles2::GetGLContext()->GetShaderPrecisionFormat(
@@ -371,6 +389,7 @@
}
void GLES2GetShaderSource(
GLuint shader, GLsizei bufsize, GLsizei* length, char* source) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLsizei, length);
GPU_CLIENT_LOG(
"GetShaderSource" << "(" << shader << ", " << bufsize << ", " << length << ", " << source << ")"); // NOLINT
gles2::GetGLContext()->GetShaderSource(shader, bufsize, length, source);
@@ -387,6 +406,7 @@
gles2::GetGLContext()->GetTexParameterfv(target, pname, params);
}
void GLES2GetTexParameteriv(GLenum target, GLenum pname, GLint* params) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
GPU_CLIENT_LOG(
"GetTexParameteriv" << "(" << target << ", " << pname << ", " << params << ")"); // NOLINT
gles2::GetGLContext()->GetTexParameteriv(target, pname, params);
@@ -397,6 +417,7 @@
gles2::GetGLContext()->GetUniformfv(program, location, params);
}
void GLES2GetUniformiv(GLuint program, GLint location, GLint* params) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
GPU_CLIENT_LOG(
"GetUniformiv" << "(" << program << ", " << location << ", " << params << ")"); // NOLINT
gles2::GetGLContext()->GetUniformiv(program, location, params);
@@ -414,6 +435,7 @@
gles2::GetGLContext()->GetVertexAttribfv(index, pname, params);
}
void GLES2GetVertexAttribiv(GLuint index, GLenum pname, GLint* params) {
+ GL_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
GPU_CLIENT_LOG(
"GetVertexAttribiv" << "(" << index << ", " << pname << ", " << params << ")"); // NOLINT
gles2::GetGLContext()->GetVertexAttribiv(index, pname, params);
« no previous file with comments | « gpu/command_buffer/client/gles2_c_lib.cc ('k') | gpu/command_buffer/client/gles2_demo_cc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698