Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 5254006: Initialize destinations variables before calling GL functions... (Closed)

Created:
10 years ago by greggman
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, ddorwin+watch_chromium.org, Alpha Left Google, apatrick_chromium, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, awong, brettw-cc_chromium.org, darin-cc_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Initialize destinations variables before calling GL functions because if the context is lost those variables will be uninitialized. TEST=ran chrome, conformance tests, unit tests and hand edited gles2_demo to test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68480

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -14 lines) Patch
M app/gfx/gl/gl_context.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/gpu/gpu_info_collector_mac.mm View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 8 chunks +37 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 9 chunks +22 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_demo_cc.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M media/tools/player_x11/gl_video_renderer.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M media/tools/player_x11/gles_video_renderer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698