Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/ia32/fast-codegen-ia32.cc

Issue 521019: Style cleanup of switches over Slot::Type in the nonoptimizing code... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/fast-codegen-ia32.cc
===================================================================
--- src/ia32/fast-codegen-ia32.cc (revision 3529)
+++ src/ia32/fast-codegen-ia32.cc (working copy)
@@ -231,7 +231,7 @@
Operand FastCodeGenerator::CreateSlotOperand<Operand>(Slot* source,
Register scratch) {
switch (source->type()) {
- case Slot::PARAMETER:
+ case Slot::PARAMETER: // Fall through.
case Slot::LOCAL:
return Operand(ebp, SlotOffset(source));
case Slot::CONTEXT: {
@@ -239,15 +239,12 @@
function_->scope()->ContextChainLength(source->var()->scope());
__ LoadContext(scratch, context_chain_length);
return CodeGenerator::ContextOperand(scratch, source->index());
- break;
}
case Slot::LOOKUP:
UNIMPLEMENTED();
- // Fall-through.
- default:
- UNREACHABLE();
- return Operand(eax, 0); // Dead code to make the compiler happy.
}
+ UNREACHABLE();
+ return Operand(eax, 0);
}
@@ -322,8 +319,6 @@
}
case Slot::LOOKUP:
UNIMPLEMENTED();
- default:
- UNREACHABLE();
}
}
@@ -573,8 +568,6 @@
case Slot::LOOKUP:
UNIMPLEMENTED();
break;
- default:
- UNREACHABLE();
}
}
Move(context, slot, eax);

Powered by Google App Engine
This is Rietveld 408576698