Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/x64/fast-codegen-x64.cc

Issue 521019: Style cleanup of switches over Slot::Type in the nonoptimizing code... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/arm/fast-codegen-arm.cc ('K') | « src/ia32/fast-codegen-ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/fast-codegen-x64.cc
===================================================================
--- src/x64/fast-codegen-x64.cc (revision 3529)
+++ src/x64/fast-codegen-x64.cc (working copy)
@@ -240,7 +240,7 @@
Operand FastCodeGenerator::CreateSlotOperand<Operand>(Slot* source,
Register scratch) {
switch (source->type()) {
- case Slot::PARAMETER:
+ case Slot::PARAMETER: // Fall through.
case Slot::LOCAL:
return Operand(rbp, SlotOffset(source));
case Slot::CONTEXT: {
@@ -248,15 +248,12 @@
function_->scope()->ContextChainLength(source->var()->scope());
__ LoadContext(scratch, context_chain_length);
return CodeGenerator::ContextOperand(scratch, source->index());
- break;
}
case Slot::LOOKUP:
UNIMPLEMENTED();
- // Fall-through.
- default:
- UNREACHABLE();
- return Operand(rax, 0); // Dead code to make the compiler happy.
}
+ UNREACHABLE();
+ return Operand(rax, 0);
}
@@ -331,8 +328,6 @@
}
case Slot::LOOKUP:
UNIMPLEMENTED();
- default:
- UNREACHABLE();
}
}
@@ -583,8 +578,6 @@
case Slot::LOOKUP:
UNIMPLEMENTED();
break;
- default:
- UNREACHABLE();
}
}
Move(context, slot, rax);
« src/arm/fast-codegen-arm.cc ('K') | « src/ia32/fast-codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698