Style cleanup of switches over Slot::Type in the nonoptimizing code...

src/ia32/fast-codegen-ia32.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 213 matching lines @@
       __ jmp(true_label_);
     }
   }
 }
 
 
 template <>
 Operand FastCodeGenerator::CreateSlotOperand<Operand>(Slot* source,
                                                       Register scratch) {
   switch (source->type()) {
-    case Slot::PARAMETER:
+    case Slot::PARAMETER:  // Fall through.
     case Slot::LOCAL:
       return Operand(ebp, SlotOffset(source));
     case Slot::CONTEXT: {
       int context_chain_length =
           function_->scope()->ContextChainLength(source->var()->scope());
       __ LoadContext(scratch, context_chain_length);
       return CodeGenerator::ContextOperand(scratch, source->index());
-      break;
     }
     case Slot::LOOKUP:
       UNIMPLEMENTED();
-      // Fall-through.
-    default:
-      UNREACHABLE();
-      return Operand(eax, 0);  // Dead code to make the compiler happy.
   }
+  UNREACHABLE();
+  return Operand(eax, 0);
 }
 
 
 void FastCodeGenerator::Move(Register dst, Slot* source) {
   Operand location = CreateSlotOperand<Operand>(source, dst);
   __ mov(dst, location);
 }
 
 
 void FastCodeGenerator::Move(Expression::Context context,
@@ skipping 54 matching lines @@
       int context_chain_length =
           function_->scope()->ContextChainLength(dst->var()->scope());
       __ LoadContext(scratch1, context_chain_length);
       __ mov(Operand(scratch1, Context::SlotOffset(dst->index())), src);
       int offset = FixedArray::kHeaderSize + dst->index() * kPointerSize;
       __ RecordWrite(scratch1, offset, src, scratch2);
       break;
     }
     case Slot::LOOKUP:
       UNIMPLEMENTED();
-    default:
-      UNREACHABLE();
   }
 }
 
 
 void FastCodeGenerator::DropAndMove(Expression::Context context,
                                     Register source,
                                     int count) {
   ASSERT(count > 0);
   switch (context) {
     case Expression::kUninitialized:
@@ skipping 229 matching lines @@
           Comment cmnt(masm_, "Stack slot");
           break;
         }
         case Slot::CONTEXT: {
           Comment cmnt(masm_, "Context slot");
           break;
         }
         case Slot::LOOKUP:
           UNIMPLEMENTED();
           break;
-        default:
-          UNREACHABLE();
       }
     }
     Move(context, slot, eax);
   } else {
     Comment cmnt(masm_, "Variable rewritten to Property");
     // A variable has been rewritten into an explicit access to
     // an object property.
     Property* property = rewrite->AsProperty();
     ASSERT_NOT_NULL(property);
 
@@ skipping 1114 matching lines @@
   __ add(Operand(edx), Immediate(masm_->CodeObject()));
   __ mov(Operand(esp, 0), edx);
   // And return.
   __ ret(0);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal