Style cleanup of switches over Slot::Type in the nonoptimizing code...

src/arm/fast-codegen-arm.cc

Index: src/arm/fast-codegen-arm.cc
===================================================================
--- src/arm/fast-codegen-arm.cc	(revision 3529)
+++ src/arm/fast-codegen-arm.cc	(working copy)
@@ -252,7 +252,7 @@
     Slot* source,
     Register scratch) {
   switch (source->type()) {
-    case Slot::PARAMETER:
+    case Slot::PARAMETER:  // Fall through.

[Lasse Reichstein, 2010/01/05 06:16:57]

I think two cases immediately after each other is a known idion, and doesn't
need the "Fall through" comment.
I would reserve that for falling through a case that actually does something.

[Lasse Reichstein, 2010/01/05 06:17:52]

"Idiom", even.

     case Slot::LOCAL:
       return MemOperand(fp, SlotOffset(source));
     case Slot::CONTEXT: {
@@ -260,15 +260,12 @@
           function_->scope()->ContextChainLength(source->var()->scope());
       __ LoadContext(scratch, context_chain_length);
       return CodeGenerator::ContextOperand(scratch, source->index());
-      break;
     }
     case Slot::LOOKUP:
       UNIMPLEMENTED();
-      // Fall-through.
-    default:
-      UNREACHABLE();
-      return MemOperand(r0, 0);  // Dead code to make the compiler happy.
   }
+  UNREACHABLE();
+  return MemOperand(r0, 0);
 }
 
 
@@ -337,8 +334,6 @@
     }
     case Slot::LOOKUP:
       UNIMPLEMENTED();
-    default:
-      UNREACHABLE();
   }
 }
 
@@ -563,7 +558,7 @@
     Slot* slot = rewrite->AsSlot();
     if (FLAG_debug_code) {
       switch (slot->type()) {
-        case Slot::LOCAL:
+        case Slot::LOCAL:  // Fall through.
         case Slot::PARAMETER: {
           Comment cmnt(masm_, "Stack slot");
           break;
@@ -575,8 +570,6 @@
         case Slot::LOOKUP:
           UNIMPLEMENTED();
           break;
-        default:
-          UNREACHABLE();
       }
     }
     Move(context, slot, r0);