Style cleanup of switches over Slot::Type in the nonoptimizing code...

Style cleanup of switches over Slot::Type in the nonoptimizing code
generator.

The Slot::Type enumeration has four values.  It should never be
necessary to use a default to handle the case of a value out of range
of the enumeration.  Doing so silences a useful warning when one of
the enumeration values is actually forgotten or when a new enumeration
value is added.


Committed: http://code.google.com/p/v8/source/detail?r=3532

[Lasse Reichstein, 2010-01-05 06:16:57]

LGTM

http://codereview.chromium.org/521019/diff/1/5
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/521019/diff/1/5#newcode255
src/arm/fast-codegen-arm.cc:255: case Slot::PARAMETER:  // Fall through.
I think two cases immediately after each other is a known idion, and doesn't
need the "Fall through" comment.
I would reserve that for falling through a case that actually does something.

[Lasse Reichstein, 2010-01-05 06:17:52]

http://codereview.chromium.org/521019/diff/1/5
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/521019/diff/1/5#newcode255
src/arm/fast-codegen-arm.cc:255: case Slot::PARAMETER:  // Fall through.
"Idiom", even.