Issue 5151006: New offline page

Issue 5151006: New offline page (Closed)

Created:
10 years, 1 month ago by oshima

Modified:
9 years, 4 months ago

Reviewers:
tony, arv (Not doing code reviews), DaveMoore

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

New offline page that is closer to mock. This is intermediate solution and I will work on merging chrome's error page and offline page after beta. BUG=chromium-os:5066, chromium-os:8285 TEST=turn off wifi, disconnect ethernet. open app from ntp and/or type in url in omnibox. New offline page should be shown as in 5066. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66713

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Total comments: 17

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -92 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+13 lines, -5 lines	2 comments	Download
M	chrome/browser/chromeos/offline/offline_load_page.h	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/offline/offline_load_page.cc	View	1 2	4 chunks	+80 lines, -15 lines	0 comments	Download
M	chrome/browser/resources/offline_load.html	View		2 chunks	+71 lines, -72 lines	15 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

Drive by review http://codereview.chromium.org/5151006/diff/6001/chrome/browser/resources/offline_load.html File chrome/browser/resources/offline_load.html (right): http://codereview.chromium.org/5151006/diff/6001/chrome/browser/resources/offline_load.html#newcode21 chrome/browser/resources/offline_load.html:21: padding: 0px; s/0px/0/ http://codereview.chromium.org/5151006/diff/6001/chrome/browser/resources/offline_load.html#newcode42 chrome/browser/resources/offline_load.html:42: margin-right: ...

10 years, 1 month ago (2010-11-19 20:09:46 UTC) #3

oshima

Thanks. I'll address them in followup CL. On 2010/11/19 20:09:46, arv wrote: > Drive by ...

10 years, 1 month ago (2010-11-20 02:37:40 UTC) #4

oshima

updated in http://codereview.chromium.org/5283002/ http://codereview.chromium.org/5151006/diff/6001/chrome/browser/resources/offline_load.html File chrome/browser/resources/offline_load.html (right): http://codereview.chromium.org/5151006/diff/6001/chrome/browser/resources/offline_load.html#newcode21 chrome/browser/resources/offline_load.html:21: padding: 0px; On 2010/11/19 20:09:49, arv ...

10 years, 1 month ago (2010-11-23 20:46:38 UTC) #5

tony

9 years, 4 months ago (2011-08-04 17:33:48 UTC) #6

http://codereview.chromium.org/5151006/diff/6001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/5151006/diff/6001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:7408: The webpage at <ph
name="HOST_NAME">&lt;strong&gt;$1<ex>www.offline.com</ex>&lt;/strong&gt;</ph>
cannot be reached because your network connection is down. The page will be
loaded when the network connection is restored. &lt;br&gt;
&lt;br&gt; should be in a <ph> tag so translators don't accidentally remove or
mangle them.

http://codereview.chromium.org/5151006/diff/6001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:7412: The app at <ph
name="HOST_NAME">&lt;strong&gt;$1<ex>www.offline.com</ex>&lt;/strong&gt;</ph>
cannot be reached because your network connection is down. The page will be
loaded when the network connection is restored. &lt;br&gt;
&lt;br&gt; should be in a <ph> tag so translators don't accidentally remove or
mangle them.

Expand Messages | Collapse Messages