chrome/browser/resources/offline_load.html - Issue 5151006: New offline page

Unified Diff: chrome/browser/resources/offline_load.html

Issue 5151006: New offline page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: " Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: chrome/browser/resources/offline_load.html

diff --git a/chrome/browser/resources/offline_load.html b/chrome/browser/resources/offline_load.html

index b2042a3e82dfe6375e7ec5de74a92b78815430c7..1c1f002ea35ea9cda55a57e5bf23acd20ed04228 100644

--- a/chrome/browser/resources/offline_load.html

+++ b/chrome/browser/resources/offline_load.html

@@ -1,75 +1,67 @@

<!DOCTYPE html>

<head>

-<title i18n-content="title"></title>

+<title i18n-content="title">

+</title>

<style>

-body {

- background-color:#E0E0E0;

- font-family:Helvetica,Arial,sans-serif;

- margin:0px;

- visibility: hidden;

-.background {

- position:absolute;

- width:100%;

- height:100%;

-.cell {

- padding:40px;

-.box {

- width:80%;

- background-color:white;

- color:black;

- font-size:10pt;

- line-height:16pt;

- text-align:left;

- padding:20px;

- position:relative;

- -webkit-box-shadow:3px 3px 8px #200;

- border-radius:5px;

+html {

+ height: 100%;

}

-html[dir='rtl'] .box {

- text-align:right;

+body {

+ color: #000;

+ font-family: Helvetica, Arial, sans-serif;

+ background-image: -webkit-gradient(

+ linear,

+ left bottom,

+ left top,

+ color-stop(0, rgb(236,244,255)),

+ color-stop(0.50, rgb(255,255,255))

+ );

+ height: 100%;

+ padding: 0px;

arv (Not doing code reviews) 2010/11/19 20:09:49 s/0px/0/

oshima 2010/11/23 20:46:38 Done.

+ margin: 0px;

+ display: -webkit-box;

+ -webkit-box-orient: horizontal;

}

-.icon {

- position:absolute;

+#spacer {

+ -webkit-box-flex: 0.5;

}

-.title {

- margin:0px 87px 0px;

- font-size:18pt;

- line-height: 140%;

- margin-bottom:6pt;

- font-weight:bold;

- color:#660000;

+#error {

+ margin-top: 150px;

+ font-size: 24px;

+ -webkit-box-flex: 1;

+ display: -webkit-box;

+ -webkit-box-orient: horizontal;

+ max-width : 800px;

+ width: 80%;

}

-.main {

- margin:0px 90px 0px;

+#error img {

+ margin-right: 10px;

arv (Not doing code reviews) 2010/11/19 20:09:49 -webkit-margin-end

oshima 2010/11/23 20:46:38 Done.

+ vertical-align: middle;

+ -webkit-box-flex: 0;

}

-.submission {

- margin:15px 5px 15px 0px;

- padding:0px;

+#error #msg_box {

+ vertical-align: middle;

+ -webkit-box-flex: 1;

}

-input {

- margin:0px;

+#heading {

+ font-weight: bold;

}

-.thumbnail {

- background-repeat: no-repeat;

- background-position: center center;

- width:400px;

- height:250px;

- padding:20px;

- position:relative;

- -webkit-box-shadow:3px 3px 8px #200;

- border-radius:5px;

- visibility: hidden;

+#msg {

+ font-size: 16px;

}

+#msg_box a {

arv (Not doing code reviews) 2010/11/19 20:09:49 a inherits font-size so this can be removed

oshima 2010/11/23 20:46:38 Changed to use 16px in #error. heading is changed

+ font-size: 16px;

}

-</style>

+</style>

function sendCommand(cmd) {

window.domAutomationController.setAutomationId(1);

@@ -86,22 +78,29 @@ function startTimer(time) {

}

</script>

</head>

-<body oncontextmenu="return false;" i18n-values="onload:on_load">

-<table width="100%" cellspacing="0" cellpadding="0">

- <td class="cell" valign="middle" align="center">

- <div class="box" id="box">

- <div class="title" i18n-content="headLine"></div>

- <div class="main" i18n-values=".innerHTML:description"></div>

- <div class="main">

- <form class="submission">

- <input type="button" name="continue_button" i18n-values="value:load_button" onclick="sendCommand('proceed')"><br>

- <input type="button" name="back_button" i18n-values="value:back_button;.style.display:display_go_back" onclick="sendCommand('dontproceed')">

- </form>

- </div>

- <div id="thumbnail" class="thumbnail" i18n-values=".style.background-image:thumbnailUrl">

- </div>

- </td>

-</table>

+<body oncontextmenu="return false;" jsvalues="onload:on_load">

arv (Not doing code reviews) 2010/11/19 20:09:49 Why do you want to prevent the context menu?

arv (Not doing code reviews) 2010/11/19 20:09:49 This solution to inject js to call onload is prett

+<div id="spacer"> </div>

arv (Not doing code reviews) 2010/11/19 20:09:49 This is not needed, neither is the other spacer.

oshima 2010/11/23 20:46:38 I had to use webkit-box-pack. let me know if i'm d

+<div id="error" jsvalues=".title:url">

+ <img i18n-values=".src:icon;.style.display:display_icon"

+ width="96" height="96">

arv (Not doing code reviews) 2010/11/19 20:09:49 move to css

oshima 2010/11/23 20:46:38 Done.

+ <div id="msg_box">

+ <div id="headling" i18n-values=".innerText:heading"></div>

arv (Not doing code reviews) 2010/11/19 20:09:49 i18n-content="heading"

arv (Not doing code reviews) 2010/11/19 20:09:49 headings should be done using hx elements

oshima 2010/11/23 20:46:38 Done.

+ <div id="msg" i18n-values=".innerHTML:msg"></div>

+ <button id="continue_button" i18n-content="load_button"

+ onclick="sendCommand('proceed')">

+ </button>

+ <button id="cancel_button" i18n-content="cancel_button"

+ i18n-values=".style.display:display_cancel"

+ onclick="sendCommand('dontproceed')">

+ </button>

+ <a href="chrome://settings/internet"

+ onclick="sendCommand('open_network_settings')"

+ i18n-content="network_settings">

+ </a>

+ </div>

+</div>

+<div id="spacer"> </div>

</body>

</html>

« chrome/app/generated_resources.grd ('K') | « chrome/browser/chromeos/offline/offline_load_page.cc ('k') | no next file » | no next file with comments »