Made chrome_test to fail when the test itself failed.

Made chrome_test to fail when the test itself failed.
Exclude tests that does not pass on valgrind

BUG=29578, 29579, 29853, 29586, 29587, 29592, 29598
TEST=run valgrind test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34403

[oshima, 2009-12-08 23:48:55]

Stuart, can you test this cl with valgrind?

[not_the_right_glider, 2009-12-09 10:35:19]

[+timurrrr]
This CL may make our ThreadSanitizer bots red as well, because even more tests
fail under TSan.

OTOH I'd really appreciate if those are fixed and this CL makes its way to the
repository, so let me file the appropriate bugs.

[not_the_right_glider, 2009-12-09 11:49:10]

Turned out there are not that many of them.
See http://crbug.com/29855

Mitsuru, could you please also disable StackTrace.OutputToStream from running on
ThreadSanitizer on Mac OS?

[oshima, 2009-12-09 18:04:12]

Ok, I need to check tsan for linux then. Thank you for reminding me.
I'll let you know when it's ready.

- oshima

On Wed, Dec 9, 2009 at 3:49 AM, <ramosian.glider@gmail.com> wrote:

> Turned out there are not that many of them.
> See http://crbug.com/29855
>
> Mitsuru, could you please also disable StackTrace.OutputToStream from
> running on
> ThreadSanitizer on Mac OS?
>
>
> http://codereview.chromium.org/466047
>

[stuartmorgan, 2009-12-09 18:51:25]

http://codereview.chromium.org/466047/diff/5005/5009
File tools/valgrind/valgrind_test.py (right):

http://codereview.chromium.org/466047/diff/5005/5009#newcode281
tools/valgrind/valgrind_test.py:281: return retcode;
This is early return isn't what we want, since it will hide any valgrind issues.
The return code should be carried forward to be returned after Analyze runs.

[oshima, 2009-12-09 20:13:34]

Done. I included StackTrace.OutputToStream in base_unittests.gtest-tsan_mac.txt.

Could you please run the test on mac?


On 2009/12/09 18:51:25, stuartmorgan wrote:
> http://codereview.chromium.org/466047/diff/5005/5009
> File tools/valgrind/valgrind_test.py (right):
> 
> http://codereview.chromium.org/466047/diff/5005/5009#newcode281
> tools/valgrind/valgrind_test.py:281: return retcode;
> This is early return isn't what we want, since it will hide any valgrind
issues.
> The return code should be carried forward to be returned after Analyze runs.

[stuartmorgan, 2009-12-09 23:40:19]

LGTM

[oshima, 2009-12-09 23:44:48]

On 2009/12/09 23:40:19, stuartmorgan wrote:
> LGTM

Alex, did ThreadSanitizer test pass on mac?

Dan, could you please review this on linux side?

Thanks,

[Alexander Potapenko, 2009-12-10 10:43:29]

> Alex, did ThreadSanitizer test pass on mac?
Yes, it's ok. Thank you.

[not_the_right_dank, 2009-12-10 10:47:13]

On Wed, Dec 9, 2009 at 3:44 PM,  <oshima@chromium.org> wrote:
> Dan, could you please review this on linux side?

LGTM.  Go ahead and commit, but stand by to revert if any bots
go red (and you're not sure you can fix immediately).  Thanks!
- Dan

[oshima, 2009-12-11 20:49:55]

Ok, linux_view/chromeos buildbots are now green. I need to check in 491058 to
make it more stable, but will check this in once it's landed.

On 2009/12/10 10:47:13, not_the_right_dank wrote:
> On Wed, Dec 9, 2009 at 3:44 PM,  <mailto:oshima@chromium.org> wrote:
> > Dan, could you please review this on linux side?
> 
> LGTM.  Go ahead and commit, but stand by to revert if any bots
> go red (and you're not sure you can fix immediately).  Thanks!
> - Dan
>