Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: tools/valgrind/valgrind_test.py

Issue 466047: Made chrome_test to fail when the test itself failed. (Closed)
Patch Set: removed CookieMonsterTest.TestLastAccess from exclusion list. Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/valgrind/ui_tests.gtest_mac.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/valgrind_test.py
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py
index ecc504d88d8c39d5bcc58b28e8c238e2152ec034..fa164e592bcda47479728f57839c9d55abbf7475 100755
--- a/tools/valgrind/valgrind_test.py
+++ b/tools/valgrind/valgrind_test.py
@@ -260,11 +260,7 @@ class ValgrindTool(object):
os.putenv("GTEST_DEATH_TEST_USE_FORK", "1")
logging.info("export GTEST_DEATH_TEST_USE_FORK=1");
- common.RunSubprocess(proc, self._timeout)
-
- # Always return true, even if running the subprocess failed. We depend on
- # Analyze to determine if the run was valid.
- return True
+ return common.RunSubprocess(proc, self._timeout)
def Analyze(self):
raise RuntimeError, "This method should be implemented " \
@@ -279,12 +275,17 @@ class ValgrindTool(object):
def RunTestsAndAnalyze(self):
self.PrepareForTest()
- self.Execute()
+ exec_retcode = self.Execute()
+ analyze_retcode = self.Analyze()
- retcode = self.Analyze()
- if retcode:
+ if analyze_retcode:
logging.error("Analyze failed.")
- return retcode
+ return analyze_retcode
+
+ if exec_retcode:
+ logging.error("Test Execution failed.")
+ return exec_retcode
+
logging.info("Execution and analysis completed successfully.")
return 0
« no previous file with comments | « chrome/test/data/valgrind/ui_tests.gtest_mac.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698