Made chrome_test to fail when the test itself failed.

tools/valgrind/valgrind_test.py

 #!/usr/bin/python
 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # valgrind_test.py
 
 '''Runs an exe through Valgrind and puts the intermediate files in a
 directory.
 '''
@@ skipping 242 matching lines @@
     logging.info("starting execution...")
 
     proc = self.ValgrindCommand()
     os.putenv("G_SLICE", "always-malloc")
     logging.info("export G_SLICE=always-malloc");
     os.putenv("NSS_DISABLE_ARENA_FREE_LIST", "1")
     logging.info("export NSS_DISABLE_ARENA_FREE_LIST=1");
     os.putenv("GTEST_DEATH_TEST_USE_FORK", "1")
     logging.info("export GTEST_DEATH_TEST_USE_FORK=1");
 
-    common.RunSubprocess(proc, self._timeout)
-
-    # Always return true, even if running the subprocess failed. We depend on
-    # Analyze to determine if the run was valid.
-    return True
+    return common.RunSubprocess(proc, self._timeout)
 
   def Analyze(self):
     raise RuntimeError, "This method should be implemented " \
                         "in the tool-specific subclass"
 
   def Cleanup(self):
     # Right now, we can cleanup by deleting our temporary directory. Other
     # cleanup is still a TODO?
     if not self._nocleanup_on_exit:
       shutil.rmtree(self.TMP_DIR, ignore_errors=True)
     return True
 
   def RunTestsAndAnalyze(self):
     self.PrepareForTest()
-    self.Execute()
+    exec_retcode = self.Execute()
+    analyze_retcode = self.Analyze()
 
-    retcode = self.Analyze()
-    if retcode:
+    if analyze_retcode:
       logging.error("Analyze failed.")
-      return retcode
+      return analyze_retcode
+
+    if exec_retcode:
+      logging.error("Test Execution failed.")
+      return exec_retcode
+
     logging.info("Execution and analysis completed successfully.")
     return 0
 
   def CreateBrowserWrapper(self, command):
     """The program being run invokes Python or something else
     that can't stand to be valgrinded, and also invokes
     the Chrome browser.  Set an environment variable to
     tell the program to prefix the Chrome commandline
     with a magic wrapper.  Build the magic wrapper here.
     """
@@ skipping 184 matching lines @@
 
 if __name__ == "__main__":
   if sys.argv.count("-v") > 0 or sys.argv.count("--verbose") > 0:
     google.logging_utils.config_root(logging.DEBUG)
   else:
     google.logging_utils.config_root()
   # TODO(timurrrr): valgrind tools may use -v/--verbose as well
 
   ret = RunTool(sys.argv)
   sys.exit(ret)