Deleted code associated with --enable-gpu-rendering and...

Deleted code associated with --enable-gpu-rendering and
--enable-video-layering flags. With the introduction of accelerated
compositing to Chromium this code is now obsolete, and it is causing
problems and bug reports when users experiment with these flags.

Tested on Linux in the following configurations:
 - Compositor on, CSS 3D content
 - Compositor on, HTML5 video content
 - Compositor off, HTML5 video content

Also ran patch successfully through the try bots.

BUG=54932
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65383

[apatrick, 2010-11-05 02:53:31]

LGTM

[scherkus (not reviewing), 2010-11-05 19:15:25]

http://codereview.chromium.org/4399003/diff/89001/90008
File chrome/browser/renderer_host/render_widget_host_view_gtk.cc (left):

http://codereview.chromium.org/4399003/diff/89001/90008#oldcode782
chrome/browser/renderer_host/render_widget_host_view_gtk.cc:782: return new
VideoLayerX(host_, size,
yeah and this class too :(

http://codereview.chromium.org/4399003/diff/89001/90009
File chrome/browser/renderer_host/render_widget_host_view_gtk.h (left):

http://codereview.chromium.org/4399003/diff/89001/90009#oldcode85
chrome/browser/renderer_host/render_widget_host_view_gtk.h:85: virtual
VideoLayer* AllocVideoLayer(const gfx::Size& size);
I'd also get rid of all the AllocVideoLayer crud

http://codereview.chromium.org/4399003/diff/89001/90011
File chrome/browser/renderer_host/render_widget_host_view_views.h (left):

http://codereview.chromium.org/4399003/diff/89001/90011#oldcode74
chrome/browser/renderer_host/render_widget_host_view_views.h:74: virtual
VideoLayer* AllocVideoLayer(const gfx::Size& size);
ditto

[brettw, 2010-11-05 21:19:21]

Something you missed:

I think the painted_synchronously out param in BackingStore.PaintToBackingStore
can be removed. I added it in:
http://src.chromium.org/viewvc/chrome?view=rev&revision=36075

Remove GPU_PROCESS from chrome/common/child_process_info.h

It looks like the original set of GPU messages I added in 
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/gpu_messages_in...
can be removed. For example, GpuMsg_NewBackingStore and probably the other
functions there as well.

[Ken Russell (switch to Gerrit), 2010-11-05 22:41:05]

On 2010/11/05 21:19:21, brettw wrote:
> Something you missed:
> 
> I think the painted_synchronously out param in
BackingStore.PaintToBackingStore
> can be removed. I added it in:
> http://src.chromium.org/viewvc/chrome?view=rev&revision=36075

Done.

> Remove GPU_PROCESS from chrome/common/child_process_info.h

This is still needed. The accelerated compositor uses the GPU process in its
current form.

> It looks like the original set of GPU messages I added in 
>
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/gpu_messages_in...
> can be removed. For example, GpuMsg_NewBackingStore and probably the other
> functions there as well.

These have already been removed in this CL.

[Ken Russell (switch to Gerrit), 2010-11-05 22:42:03]

New version of CL includes the following changes:

 - Removed VideoLayer class completely and
RenderWidgetHostView::AllocVideoLayer.

 - Removed video-related ViewHostMsg creation / update / ACK messages.

 - Removed painted_synchronously parameter from
BackingStore::PaintToBackingStore and callers.

http://codereview.chromium.org/4399003/diff/89001/90008
File chrome/browser/renderer_host/render_widget_host_view_gtk.cc (left):

http://codereview.chromium.org/4399003/diff/89001/90008#oldcode782
chrome/browser/renderer_host/render_widget_host_view_gtk.cc:782: return new
VideoLayerX(host_, size,
On 2010/11/05 19:15:26, scherkus wrote:
> yeah and this class too :(

Done.

http://codereview.chromium.org/4399003/diff/89001/90009
File chrome/browser/renderer_host/render_widget_host_view_gtk.h (left):

http://codereview.chromium.org/4399003/diff/89001/90009#oldcode85
chrome/browser/renderer_host/render_widget_host_view_gtk.h:85: virtual
VideoLayer* AllocVideoLayer(const gfx::Size& size);
On 2010/11/05 19:15:26, scherkus wrote:
> I'd also get rid of all the AllocVideoLayer crud

Done.

http://codereview.chromium.org/4399003/diff/89001/90011
File chrome/browser/renderer_host/render_widget_host_view_views.h (left):

http://codereview.chromium.org/4399003/diff/89001/90011#oldcode74
chrome/browser/renderer_host/render_widget_host_view_views.h:74: virtual
VideoLayer* AllocVideoLayer(const gfx::Size& size);
On 2010/11/05 19:15:26, scherkus wrote:
> ditto

Done.

[brettw, 2010-11-05 22:51:36]

LGTM

[scherkus (not reviewing), 2010-11-05 22:57:48]

LGTM