Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 42602: Simplify the way the code generator handles calls to IC stubs. Before... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Simplify the way the code generator handles calls to IC stubs. Before we dispatched on the IC stub kind in a generic CallCodeObject function. Now, we have special functions for the load and store IC stubs. We also (for the load and store ICs) handle moving register arguments into place only after the stack is prepared for the call. This replaces some memory-to-memory moves (for copies whose backing store is occupied by a register needed for the arguments) with memory-to-register moves. Committed: http://code.google.com/p/v8/source/detail?r=1613

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -113 lines) Patch
M src/codegen-ia32.cc View 8 chunks +31 lines, -76 lines 1 comment Download
M src/virtual-frame.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/virtual-frame-ia32.h View 1 chunk +20 lines, -7 lines 0 comments Download
M src/virtual-frame-ia32.cc View 2 chunks +63 lines, -30 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
This is the first part of an attempt to simplify handling of calls. Nothing needs ...
11 years, 9 months ago (2009-03-25 13:15:56 UTC) #1
Kasper Lund
LGTM. Maybe the register-pair-swapping could be generalized long term? http://codereview.chromium.org/42602/diff/1/5 File src/codegen-ia32.cc (right): http://codereview.chromium.org/42602/diff/1/5#newcode5190 Line ...
11 years, 9 months ago (2009-03-25 13:25:34 UTC) #2
William Hesse
11 years, 9 months ago (2009-03-25 14:27:28 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698