Issue 42017: Fix issue 265 by handling extra statement state on the frame based on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42017: Fix issue 265 by handling extra statement state on the frame based on... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fix issue 265 by handling extra statement state on the frame based on the expectation at the break, continue, and return labels (including shadowed ones) instead of based on the AST nodes. See http://code.google.com/p/v8/issues/detail?id=265 Committed: http://code.google.com/p/v8/source/detail?r=1482

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+295 lines, -210 lines)			Patch
M	src/assembler-arm.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/assembler-ia32.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	src/ast.h	View		3 chunks	+2 lines, -8 lines	0 comments	Download
M	src/codegen-arm.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/codegen-arm.cc	View	1	12 chunks	+11 lines, -32 lines	0 comments	Download
M	src/codegen-ia32.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/codegen-ia32.cc	View		13 chunks	+12 lines, -33 lines	0 comments	Download
M	src/jump-target.h	View		6 chunks	+54 lines, -20 lines	0 comments	Download
M	src/jump-target.cc	View	1 2	4 chunks	+93 lines, -18 lines	0 comments	Download
M	src/virtual-frame.cc	View		2 chunks	+20 lines, -10 lines	0 comments	Download
M	src/virtual-frame-arm.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/virtual-frame-arm.cc	View		2 chunks	+10 lines, -9 lines	0 comments	Download
M	src/virtual-frame-ia32.h	View		2 chunks	+11 lines, -4 lines	0 comments	Download
M	src/virtual-frame-ia32.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download
D	test/mjsunit/bugs/bug-265.js	View		1 chunk	+0 lines, -64 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download
A	test/mjsunit/regress/regress-265.js	View		1 chunk	+64 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

Kevin Millikin (Chromium)

11 years, 9 months ago (2009-03-11 05:50:04 UTC) #1

Now ported to ARM (as much as was necessary).