Fix a bug that could occur when converting strings with leading characters ab...

Fix a bug that could occur when converting strings with leading characters above 127.

BUG=None
TEST=base_unittests --gtest_filter=*StringToInt*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64789

[erikwright (departed), 2010-11-01 20:02:03]

Hi MAD,

Here is the fix we talked about. It's not an issue for char16 (those are always
unsigned) but only for char. I added test cases for both character types and the
char test case did fail before my change.

Cheers,

Erik

[MAD, 2010-11-01 21:13:40]

LGTM...

I guess the new test case confirms that this was the only place that was causing
trouble...

BYE
MAD

[erikwright (departed), 2010-11-02 18:44:10]

FYI. Small change to pass try-bots on Linux/Mac.

[MAD, 2010-11-02 18:53:24]

Still LGTM...

Thanks!

BYE
MAD

http://codereview.chromium.org/4129012/diff/6001/7002
File base/string_number_conversions_unittest.cc (right):

http://codereview.chromium.org/4129012/diff/6001/7002#newcode168
base/string_number_conversions_unittest.cc:168: const char16
negative_wide_input[] = { 0xFF4D, '4', '2', 0};
I was wondering about that... But didn't mention since I guess you had tried
building the patch... Next time I'll mention it anyway... :-)

[erikwright (departed), 2010-11-02 19:32:22]

http://codereview.chromium.org/4129012/diff/6001/7002
File base/string_number_conversions_unittest.cc (right):

http://codereview.chromium.org/4129012/diff/6001/7002#newcode168
base/string_number_conversions_unittest.cc:168: const char16
negative_wide_input[] = { 0xFF4D, '4', '2', 0};
On 2010/11/02 18:53:25, mad1 wrote:
> I was wondering about that... But didn't mention since I guess you had tried
> building the patch... Next time I'll mention it anyway... :-)
> 

The other one did build on Win (locally), but I was having trouble with 'gcl
try' that prevented me from submitting the job to linux+mac. Finally had to
submit a CL to depot_tools to get it to work.