base/string_number_conversions.cc - Issue 4129012: Fix a bug that could occur when converting strings with leading characters ab...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/string_number_conversions.cc

Issue 4129012: Fix a bug that could occur when converting strings with leading characters ab... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/string_number_conversions.cc

===================================================================

--- base/string_number_conversions.cc (revision 63369)

+++ base/string_number_conversions.cc (working copy)

@@ -143,7 +143,7 @@

template<> class WhitespaceHelper<char> {

public:

static bool Invoke(char c) {

- return 0 != isspace(c);

+ return 0 != isspace(static_cast<unsigned char>(c));

}

};

« no previous file with comments | « no previous file | base/string_number_conversions_unittest.cc » ('j') | base/string_number_conversions_unittest.cc » ('J')