Fix a bug that could occur when converting strings with leading characters ab...

base/string_number_conversions_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <math.h>
 
 #include <limits>
 
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
@@ skipping 62 matching lines @@
 }
 
 TEST(StringNumberConversionsTest, StringToInt) {
   static const struct {
     std::string input;
     int output;
     bool success;
   } cases[] = {
     {"0", 0, true},
     {"42", 42, true},
+    {"42\x99", 42, false},
+    {"\x99" "42\x99", 0, false},
     {"-2147483648", INT_MIN, true},
     {"2147483647", INT_MAX, true},
     {"", 0, false},
     {" 42", 42, false},
     {"42 ", 42, false},
     {"\t\n\v\f\r 42", 42, false},
     {"blah42", 0, false},
     {"42blah", 42, false},
     {"blah42blah", 0, false},
     {"-273.15", -273, false},
@@ skipping 61 matching lines @@
   EXPECT_FALSE(StringToInt(utf16_input, &output));
   EXPECT_EQ(6, output);
   output = 0;
   EXPECT_FALSE(StringToInt(utf16_input.begin(), utf16_input.end(), &output));
   EXPECT_EQ(6, output);
   output = 0;
   EXPECT_FALSE(StringToInt(utf16_chars,
                            utf16_chars + utf16_input.length(),
                            &output));
   EXPECT_EQ(6, output);
+
+  output = 0;
+  const char16 negative_wide_input[] = { 0xFF4D, '4', '2', 0};

[MAD, 2010/11/02 18:53:25]

I was wondering about that... But didn't mention since I guess you had tried
building the patch... Next time I'll mention it anyway... :-)

[erikwright (departed), 2010/11/02 19:32:22]

The other one did build on Win (locally), but I was having trouble with 'gcl
try' that prevented me from submitting the job to linux+mac. Finally had to
submit a CL to depot_tools to get it to work.

+  EXPECT_FALSE(StringToInt(string16(negative_wide_input), &output));
+  EXPECT_EQ(0, output);
 }
 
 TEST(StringNumberConversionsTest, StringToInt64) {
   static const struct {
     std::string input;
     int64 output;
     bool success;
   } cases[] = {
     {"0", 0, true},
     {"42", 42, true},
@@ skipping 254 matching lines @@
 
 TEST(StringNumberConversionsTest, HexEncode) {
   std::string hex(HexEncode(NULL, 0));
   EXPECT_EQ(hex.length(), 0U);
   unsigned char bytes[] = {0x01, 0xff, 0x02, 0xfe, 0x03, 0x80, 0x81};
   hex = HexEncode(bytes, sizeof(bytes));
   EXPECT_EQ(hex.compare("01FF02FE038081"), 0);
 }
 
 }  // namespace base