Fix a bug that could occur when converting strings with leading characters ab...

base/string_number_conversions.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_number_conversions.h"
 
 #include <errno.h>
 #include <stdlib.h>
 
 #include <limits>
@@ skipping 125 matching lines @@
 // There is an IsWhitespace for wchars defined in string_util.h, but it is
 // locale independent, whereas the functions we are replacing were
 // locale-dependent. TBD what is desired, but for the moment let's not introduce
 // a change in behaviour.
 template<typename CHAR> class WhitespaceHelper {
 };
 
 template<> class WhitespaceHelper<char> {
  public:
   static bool Invoke(char c) {
-    return 0 != isspace(c);
+    return 0 != isspace(static_cast<unsigned char>(c));
   }
 };
 
 template<> class WhitespaceHelper<char16> {
  public:
   static bool Invoke(char16 c) {
     return 0 != iswspace(c);
   }
 };
 
@@ skipping 368 matching lines @@
                                                                     end,
                                                                     output);
 }
 
 bool HexStringToBytes(const std::string& input, std::vector<uint8>* output) {
   return HexStringToBytesT(input, output);
 }
 
 }  // namespace base