Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 390004: Fix warnings on Win64. (Closed)

Created:
11 years, 1 month ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix warnings on Win64. Set warning level to /W3 and change implicit conversions from size_t to int. Most "fixes" are simply manifesting the implicit casts or using a special strlen replacement that returns int.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -289 lines) Patch
M SConstruct View 1 chunk +1 line, -1 line 0 comments Download
M src/allocation.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/api.cc View 9 chunks +16 lines, -11 lines 1 comment Download
M src/assembler.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/conversions.cc View 11 chunks +13 lines, -12 lines 0 comments Download
M src/debug.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/debug.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/debug-agent.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/disassembler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/flags.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/frames.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/global-handles.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/handles.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap.cc View 2 chunks +15 lines, -9 lines 0 comments Download
M src/ic.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter-irregexp.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M src/list.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/log.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/log-utils.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/log-utils.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/mark-compact.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/objects-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/platform-win32.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/regexp-stack.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/regexp-stack.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M src/scanner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/scopeinfo.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.h View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.cc View 16 chunks +25 lines, -20 lines 0 comments Download
M src/spaces.h View 3 chunks +5 lines, -3 lines 0 comments Download
M src/spaces.cc View 22 chunks +33 lines, -26 lines 0 comments Download
M src/utils.h View 3 chunks +11 lines, -4 lines 0 comments Download
M src/utils.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/disasm-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/zone.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 5 chunks +13 lines, -10 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-debug.cc View 15 chunks +34 lines, -20 lines 0 comments Download
M test/cctest/test-flags.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-log.cc View 9 chunks +9 lines, -8 lines 0 comments Download
M test/cctest/test-log-utils.cc View 2 chunks +2 lines, -1 line 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 23 chunks +23 lines, -23 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/test-regexp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/test-utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
High volume but pretty tedious review. Feel free to redistribute it.
11 years, 1 month ago (2009-11-10 16:33:12 UTC) #1
Lasse Reichstein
http://codereview.chromium.org/390004/diff/1/4 File src/api.cc (right): http://codereview.chromium.org/390004/diff/1/4#newcode2054 Line 2054: int buf_len = static_cast<int>(prefix_len + str_len + postfix_len); ...
11 years, 1 month ago (2009-11-10 16:37:41 UTC) #2
Mads Ager (chromium)
11 years, 1 month ago (2009-11-11 09:38:46 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698