Resubmit http://codereview.chromium.org/314016 with views fixed

Resubmit http://codereview.chromium.org/314016 with views fixed

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30106

[chron_chromium.org, 2009-10-26 20:27:37]

LGTM

On Mon, Oct 26, 2009 at 1:15 PM,  <zork@chromium.org> wrote:
> Reviewers: chron_chromium.org,
>
> Description:
> Resubmit http://codereview.chromium.org/314016 with views fixed
>
> Please review this at http://codereview.chromium.org/338008
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/browser.cc
> =A0M =A0 =A0 chrome/browser/dom_ui/new_tab_page_sync_handler.cc
> =A0M =A0 =A0 chrome/browser/dom_ui/new_tab_ui.cc
> =A0M =A0 =A0 chrome/browser/gtk/sync_setup_wizard_gtk.cc
> =A0M =A0 =A0 chrome/browser/profile.cc
> =A0M =A0 =A0 chrome/browser/sync/sync_setup_wizard.h
> =A0M =A0 =A0 chrome/browser/sync/sync_status_ui_helper.h
> =A0M =A0 =A0 chrome/browser/sync/sync_status_ui_helper.cc
> =A0M =A0 =A0 chrome/browser/views/bookmark_bar_view.cc
> =A0M =A0 =A0 chrome/browser/views/toolbar_view.cc
> =A0M =A0 =A0 chrome/chrome.gyp
>
>
>



--=20
As seen on TV

[Timur Iskhodzhanov, 2009-10-27 06:46:32]

This change might have broken ThreadSanitizer bot:
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(tsan)/...

The race reports contain browser_sync:: in stack traces.
This may be related to the new data races being introduces OR the old data races
revealed by the change in chrome/chrome.gyp

I'll investigate the issue and file a bug if appropriate

On 2009/10/26 20:27:37, chron_chromium.org wrote:
> LGTM
> 
> On Mon, Oct 26, 2009 at 1:15 PM,  <mailto:zork@chromium.org> wrote:
> > Reviewers: http://chron_chromium.org,
> >
> > Description:
> > Resubmit http://codereview.chromium.org/314016 with views fixed
> >
> > Please review this at http://codereview.chromium.org/338008
> >
> > SVN Base: svn://chrome-svn/chrome/trunk/src/
> >
> > Affected files:
> > =A0M =A0 =A0 chrome/browser/browser.cc
> > =A0M =A0 =A0 chrome/browser/dom_ui/new_tab_page_sync_handler.cc
> > =A0M =A0 =A0 chrome/browser/dom_ui/new_tab_ui.cc
> > =A0M =A0 =A0 chrome/browser/gtk/sync_setup_wizard_gtk.cc
> > =A0M =A0 =A0 chrome/browser/profile.cc
> > =A0M =A0 =A0 chrome/browser/sync/sync_setup_wizard.h
> > =A0M =A0 =A0 chrome/browser/sync/sync_status_ui_helper.h
> > =A0M =A0 =A0 chrome/browser/sync/sync_status_ui_helper.cc
> > =A0M =A0 =A0 chrome/browser/views/bookmark_bar_view.cc
> > =A0M =A0 =A0 chrome/browser/views/toolbar_view.cc
> > =A0M =A0 =A0 chrome/chrome.gyp
> >
> >
> >
> 
> 
> 
> --=20
> As seen on TV