Issue 314016: Build sync by default on all platforms. Add a command line parameter to enab...

Issue 314016: Build sync by default on all platforms. Add a command line parameter to enab... (Closed)

Created:
11 years, 2 months ago by Zachary Kuznia

Modified:
7 years, 3 months ago

Reviewers:
chron_chromium.org

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Build sync by default on all platforms. This also turns off sync on both Linux and Mac, so that even though the code is compiled, it won't run. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29961

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 2

Patch Set 7 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -11 lines)			Patch
M	chrome/browser/browser.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/sync_setup_wizard_gtk.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/profile.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1	11 chunks	+22 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

chron_chromium.org

http://codereview.chromium.org/314016/diff/8009/8011 File chrome/browser/browser.cc (right): http://codereview.chromium.org/314016/diff/8009/8011#newcode656 Line 656: #if defined(BROWSER_SYNC) We should get rid of this ...

11 years, 2 months ago (2009-10-23 20:51:17 UTC) #2

zork

Setting browser_sync to 0 in chrome.gyp or include.gypi successfully removes sync. -Zach On Fri, Oct ...

11 years, 2 months ago (2009-10-23 21:43:12 UTC) #3

chron_chromium.org

11 years, 2 months ago (2009-10-23 21:45:01 UTC) #4

LGTM

On Fri, Oct 23, 2009 at 2:42 PM, Zach Kuznia <zork@google.com> wrote:
> Setting browser_sync to 0 in chrome.gyp or include.gypi successfully removes
> sync.
> -Zach
>
> On Fri, Oct 23, 2009 at 1:51 PM, <chron@chromium.org> wrote:
>>
>> http://codereview.chromium.org/314016/diff/8009/8011
>> File chrome/browser/browser.cc (right):
>>
>> http://codereview.chromium.org/314016/diff/8009/8011#newcode656
>> Line 656: #if defined(BROWSER_SYNC)
>> We should get rid of this define in an upcoming CL.
>>
>> http://codereview.chromium.org/314016/diff/8009/8012
>> File chrome/browser/dom_ui/new_tab_ui.cc (right):
>>
>> http://codereview.chromium.org/314016/diff/8009/8012#newcode564
>> Line 564: #if defined(BROWSER_SYNC) && !defined(OS_POSIX)
>> Either test building with BROWSER_SYNC off, or just remove the define.
>>
>> http://codereview.chromium.org/314016
>
>



-- 
As seen on TV

Expand Messages | Collapse Messages