Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/chrome.gyp

Issue 338008: Resubmit http://codereview.chromium.org/314016 with views fixed (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/toolbar_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
===================================================================
--- chrome/chrome.gyp (revision 30060)
+++ chrome/chrome.gyp (working copy)
@@ -127,6 +127,7 @@
'../views/controls/table/table_view_unittest.cc',
'../views/grid_layout_unittest.cc',
],
+ 'browser_sync%': 1,
'conditions': [
['OS=="win"', {
'nacl_defines': [
@@ -159,12 +160,6 @@
}], # branding
], # conditions
}], # OS=="mac"
- ['OS=="win" or OS=="mac"', {
- # Whether or not browser sync code is built in.
- 'browser_sync%': 1,
- }, {
- 'browser_sync%': 0,
- }], # OS=="win"
['target_arch=="ia32"', {
'nacl_defines': [
# TODO(gregoryd): consider getting this from NaCl's common.gypi
@@ -2892,6 +2887,8 @@
'sources/': [
['include', '^browser/printing/print_dialog_gtk.cc'],
['include', '^browser/printing/print_dialog_gtk.h'],
+ ['exclude', '^browser/sync/sync_setup_flow.cc'],
+ ['exclude', '^browser/sync/sync_setup_wizard.cc'],
],
}],
['chromeos==1 or toolkit_views==1',{
@@ -2994,6 +2991,12 @@
'../third_party/WebKit/WebCore/WebCore.gyp/WebCore.gyp:webcore',
],
}],
+ ['OS=="linux" and browser_sync==1', {
+ 'sources': [
+ 'browser/gtk/sync_setup_wizard_gtk.cc',
+ 'browser/gtk/sync_setup_wizard_gtk.h',
+ ],
+ }],
],
},
{
@@ -4686,6 +4689,7 @@
'browser/renderer_host/gtk_key_bindings_handler_unittest.cc',
],
'sources!': [
+ 'browser/sync/sync_setup_wizard_unittest.cc',
'browser/views/bookmark_context_menu_test.cc',
'browser/gtk/options/cookies_view_unittest.cc',
# Compact Language Detection (cld) is not supported in linux yet.
@@ -4822,7 +4826,6 @@
'browser/rlz/rlz_unittest.cc',
'browser/safe_browsing/safe_browsing_blocking_page_unittest.cc',
'browser/search_engines/template_url_scraper_unittest.cc',
- 'browser/sync/profile_sync_service_unittest.cc',
'browser/views/bookmark_editor_view_unittest.cc',
'browser/views/find_bar_host_unittest.cc',
'browser/views/keyword_editor_view_unittest.cc',
@@ -6704,6 +6707,9 @@
'POSIX',
'OS_LINUX',
],
+ 'dependencies': [
+ '../build/linux/system.gyp:gtk'
+ ],
}],
],
},
@@ -6724,7 +6730,6 @@
'browser/sync/syncable/syncable_unittest.cc',
'browser/sync/util/character_set_converters_unittest.cc',
'browser/sync/util/crypto_helpers_unittest.cc',
- 'browser/sync/util/data_encryption_unittest.cc',
'browser/sync/util/event_sys_unittest.cc',
'browser/sync/util/highres_timer_unittest.cc',
'browser/sync/util/path_helpers_unittest.cc',
@@ -6758,6 +6763,9 @@
],
'conditions': [
['OS=="win"', {
+ 'sources' : [
+ 'browser/sync/util/data_encryption_unittest.cc',
+ ],
'dependencies': [
'../third_party/tcmalloc/tcmalloc.gyp:tcmalloc',
],
@@ -6777,6 +6785,9 @@
'defines': [
'POSIX',
],
+ 'dependencies': [
+ '../build/linux/system.gyp:gtk'
+ ],
}],
],
},
@@ -6932,6 +6943,9 @@
'defines': [
'POSIX',
],
+ 'dependencies': [
+ '../build/linux/system.gyp:gtk'
+ ],
}],
['OS=="mac"', {
'link_settings': {
« no previous file with comments | « chrome/browser/views/toolbar_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698