Issue 337035: Replace ExtensionAction with ExtensionAction2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337035: Replace ExtensionAction with ExtensionAction2. (Closed)

Created:
11 years, 1 month ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Replace ExtensionAction with ExtensionAction2. BUG=24472 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30172

Patch Set 1 #

Patch Set 2 : whoops #

Patch Set 3 : Remove todo #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -513 lines)			Patch
M	chrome/browser/extensions/browser_action_apitest.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_browser_actions_api.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_browser_actions_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_file_util.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_page_actions_module.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_page_actions_module.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/page_action_apitest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/browser_actions_toolbar_gtk.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 2	4 chunks	+6 lines, -15 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/common/extensions/extension_action.h	View		2 chunks	+128 lines, -91 lines	0 comments	Download
M	chrome/common/extensions/extension_action.cc	View		1 chunk	+18 lines, -10 lines	0 comments	Download
D	chrome/common/extensions/extension_action2.h	View		1 chunk	+0 lines, -188 lines	0 comments	Download
D	chrome/common/extensions/extension_action2.cc	View		1 chunk	+0 lines, -132 lines	0 comments	Download
A +	chrome/common/extensions/extension_action_unittest.cc	View		6 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View		7 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm!

Expand Messages | Collapse Messages