chrome/browser/extensions/extension_page_actions_module.cc - Issue 337035: Replace ExtensionAction with ExtensionAction2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_page_actions_module.cc

Issue 337035: Replace ExtensionAction with ExtensionAction2. (Closed)

Patch Set: Remove todo Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_page_actions_module.cc

diff --git a/chrome/browser/extensions/extension_page_actions_module.cc b/chrome/browser/extensions/extension_page_actions_module.cc

index b41386d34816d0f86789ef911836683be7482f8f..528f5a44f4f56cdd42e1b6942adc8dd5f7cf3aa4 100644

--- a/chrome/browser/extensions/extension_page_actions_module.cc

+++ b/chrome/browser/extensions/extension_page_actions_module.cc

@@ -56,7 +56,7 @@ bool PageActionFunction::SetPageActionEnabled(bool enable) {

}

- ExtensionAction2* page_action = dispatcher()->GetExtension()->page_action();

+ ExtensionAction* page_action = dispatcher()->GetExtension()->page_action();

if (!page_action) {

error_ = kNoPageActionError;

return false;