Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/common/extensions/extension_action_unittest.cc

Issue 337035: Replace ExtensionAction with ExtensionAction2. (Closed)
Patch Set: Remove todo Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/extensions/extension_action2.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #include "base/file_path.h" 1 #include "base/file_path.h"
2 #include "base/file_util.h" 2 #include "base/file_util.h"
3 #include "base/path_service.h" 3 #include "base/path_service.h"
4 #include "chrome/common/chrome_paths.h" 4 #include "chrome/common/chrome_paths.h"
5 #include "chrome/common/extensions/extension_action2.h" 5 #include "chrome/common/extensions/extension_action.h"
6 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
7 #include "third_party/skia/include/core/SkBitmap.h" 7 #include "third_party/skia/include/core/SkBitmap.h"
8 #include "webkit/glue/image_decoder.h" 8 #include "webkit/glue/image_decoder.h"
9 9
10 static SkBitmap LoadIcon(const std::string& filename) { 10 static SkBitmap LoadIcon(const std::string& filename) {
11 FilePath path; 11 FilePath path;
12 PathService::Get(chrome::DIR_TEST_DATA, &path); 12 PathService::Get(chrome::DIR_TEST_DATA, &path);
13 path = path.AppendASCII("extensions").AppendASCII(filename); 13 path = path.AppendASCII("extensions").AppendASCII(filename);
14 14
15 std::string file_contents; 15 std::string file_contents;
(...skipping 16 matching lines...) Expand all
32 addr1 = bitmap1.getAddr32(0, 0); 32 addr1 = bitmap1.getAddr32(0, 0);
33 bitmap1.unlockPixels(); 33 bitmap1.unlockPixels();
34 34
35 bitmap2.lockPixels(); 35 bitmap2.lockPixels();
36 addr2 = bitmap2.getAddr32(0, 0); 36 addr2 = bitmap2.getAddr32(0, 0);
37 bitmap2.unlockPixels(); 37 bitmap2.unlockPixels();
38 38
39 return 0 == memcmp(addr1, addr2, bitmap1.getSize()); 39 return 0 == memcmp(addr1, addr2, bitmap1.getSize());
40 } 40 }
41 41
42 TEST(ExtensionAction2Test, TabSpecificState) { 42 TEST(ExtensionActionTest, TabSpecificState) {
43 ExtensionAction2 action; 43 ExtensionAction action;
44 44
45 // title 45 // title
46 ASSERT_EQ("", action.GetTitle(1)); 46 ASSERT_EQ("", action.GetTitle(1));
47 action.SetTitle(ExtensionAction2::kDefaultTabId, "foo"); 47 action.SetTitle(ExtensionAction::kDefaultTabId, "foo");
48 ASSERT_EQ("foo", action.GetTitle(1)); 48 ASSERT_EQ("foo", action.GetTitle(1));
49 ASSERT_EQ("foo", action.GetTitle(100)); 49 ASSERT_EQ("foo", action.GetTitle(100));
50 action.SetTitle(100, "bar"); 50 action.SetTitle(100, "bar");
51 ASSERT_EQ("foo", action.GetTitle(1)); 51 ASSERT_EQ("foo", action.GetTitle(1));
52 ASSERT_EQ("bar", action.GetTitle(100)); 52 ASSERT_EQ("bar", action.GetTitle(100));
53 action.SetTitle(ExtensionAction2::kDefaultTabId, "baz"); 53 action.SetTitle(ExtensionAction::kDefaultTabId, "baz");
54 ASSERT_EQ("baz", action.GetTitle(1)); 54 ASSERT_EQ("baz", action.GetTitle(1));
55 action.ClearAllValuesForTab(100); 55 action.ClearAllValuesForTab(100);
56 ASSERT_EQ("baz", action.GetTitle(100)); 56 ASSERT_EQ("baz", action.GetTitle(100));
57 57
58 // icon 58 // icon
59 SkBitmap icon1 = LoadIcon("icon1.png"); 59 SkBitmap icon1 = LoadIcon("icon1.png");
60 SkBitmap icon2 = LoadIcon("icon2.png"); 60 SkBitmap icon2 = LoadIcon("icon2.png");
61 ASSERT_TRUE(action.GetIcon(1).isNull()); 61 ASSERT_TRUE(action.GetIcon(1).isNull());
62 action.SetIcon(ExtensionAction2::kDefaultTabId, icon1); 62 action.SetIcon(ExtensionAction::kDefaultTabId, icon1);
63 ASSERT_TRUE(BitmapsAreEqual(icon1, action.GetIcon(100))); 63 ASSERT_TRUE(BitmapsAreEqual(icon1, action.GetIcon(100)));
64 action.SetIcon(100, icon2); 64 action.SetIcon(100, icon2);
65 ASSERT_TRUE(BitmapsAreEqual(icon1, action.GetIcon(1))); 65 ASSERT_TRUE(BitmapsAreEqual(icon1, action.GetIcon(1)));
66 ASSERT_TRUE(BitmapsAreEqual(icon2, action.GetIcon(100))); 66 ASSERT_TRUE(BitmapsAreEqual(icon2, action.GetIcon(100)));
67 67
68 // icon index 68 // icon index
69 ASSERT_EQ(-1, action.GetIconIndex(1)); 69 ASSERT_EQ(-1, action.GetIconIndex(1));
70 action.icon_paths()->push_back("foo.png"); 70 action.icon_paths()->push_back("foo.png");
71 action.icon_paths()->push_back("bar.png"); 71 action.icon_paths()->push_back("bar.png");
72 action.SetIconIndex(ExtensionAction2::kDefaultTabId, 1); 72 action.SetIconIndex(ExtensionAction::kDefaultTabId, 1);
73 ASSERT_EQ(1, action.GetIconIndex(1)); 73 ASSERT_EQ(1, action.GetIconIndex(1));
74 ASSERT_EQ(1, action.GetIconIndex(100)); 74 ASSERT_EQ(1, action.GetIconIndex(100));
75 action.SetIconIndex(100, 0); 75 action.SetIconIndex(100, 0);
76 ASSERT_EQ(0, action.GetIconIndex(100)); 76 ASSERT_EQ(0, action.GetIconIndex(100));
77 ASSERT_EQ(1, action.GetIconIndex(1)); 77 ASSERT_EQ(1, action.GetIconIndex(1));
78 action.ClearAllValuesForTab(100); 78 action.ClearAllValuesForTab(100);
79 ASSERT_EQ(1, action.GetIconIndex(100)); 79 ASSERT_EQ(1, action.GetIconIndex(100));
80 ASSERT_EQ(1, action.GetIconIndex(1)); 80 ASSERT_EQ(1, action.GetIconIndex(1));
81 81
82 // visibility 82 // visibility
83 ASSERT_EQ(false, action.GetIsVisible(1)); 83 ASSERT_EQ(false, action.GetIsVisible(1));
84 action.SetIsVisible(ExtensionAction2::kDefaultTabId, true); 84 action.SetIsVisible(ExtensionAction::kDefaultTabId, true);
85 ASSERT_EQ(true, action.GetIsVisible(1)); 85 ASSERT_EQ(true, action.GetIsVisible(1));
86 ASSERT_EQ(true, action.GetIsVisible(100)); 86 ASSERT_EQ(true, action.GetIsVisible(100));
87 action.SetIsVisible(ExtensionAction2::kDefaultTabId, false); 87 action.SetIsVisible(ExtensionAction::kDefaultTabId, false);
88 ASSERT_EQ(false, action.GetIsVisible(1)); 88 ASSERT_EQ(false, action.GetIsVisible(1));
89 ASSERT_EQ(false, action.GetIsVisible(100)); 89 ASSERT_EQ(false, action.GetIsVisible(100));
90 action.SetIsVisible(100, true); 90 action.SetIsVisible(100, true);
91 ASSERT_EQ(false, action.GetIsVisible(1)); 91 ASSERT_EQ(false, action.GetIsVisible(1));
92 ASSERT_EQ(true, action.GetIsVisible(100)); 92 ASSERT_EQ(true, action.GetIsVisible(100));
93 action.ClearAllValuesForTab(100); 93 action.ClearAllValuesForTab(100);
94 ASSERT_EQ(false, action.GetIsVisible(1)); 94 ASSERT_EQ(false, action.GetIsVisible(1));
95 ASSERT_EQ(false, action.GetIsVisible(100)); 95 ASSERT_EQ(false, action.GetIsVisible(100));
96 96
97 // badge text 97 // badge text
98 ASSERT_EQ("", action.GetBadgeText(1)); 98 ASSERT_EQ("", action.GetBadgeText(1));
99 action.SetBadgeText(ExtensionAction2::kDefaultTabId, "foo"); 99 action.SetBadgeText(ExtensionAction::kDefaultTabId, "foo");
100 ASSERT_EQ("foo", action.GetBadgeText(1)); 100 ASSERT_EQ("foo", action.GetBadgeText(1));
101 ASSERT_EQ("foo", action.GetBadgeText(100)); 101 ASSERT_EQ("foo", action.GetBadgeText(100));
102 action.SetBadgeText(100, "bar"); 102 action.SetBadgeText(100, "bar");
103 ASSERT_EQ("foo", action.GetBadgeText(1)); 103 ASSERT_EQ("foo", action.GetBadgeText(1));
104 ASSERT_EQ("bar", action.GetBadgeText(100)); 104 ASSERT_EQ("bar", action.GetBadgeText(100));
105 action.SetBadgeText(ExtensionAction2::kDefaultTabId, "baz"); 105 action.SetBadgeText(ExtensionAction::kDefaultTabId, "baz");
106 ASSERT_EQ("baz", action.GetBadgeText(1)); 106 ASSERT_EQ("baz", action.GetBadgeText(1));
107 action.ClearAllValuesForTab(100); 107 action.ClearAllValuesForTab(100);
108 ASSERT_EQ("baz", action.GetBadgeText(100)); 108 ASSERT_EQ("baz", action.GetBadgeText(100));
109 109
110 // badge text color 110 // badge text color
111 ASSERT_EQ(0x00000000u, action.GetBadgeTextColor(1)); 111 ASSERT_EQ(0x00000000u, action.GetBadgeTextColor(1));
112 action.SetBadgeTextColor(ExtensionAction2::kDefaultTabId, 0xFFFF0000u); 112 action.SetBadgeTextColor(ExtensionAction::kDefaultTabId, 0xFFFF0000u);
113 ASSERT_EQ(0xFFFF0000u, action.GetBadgeTextColor(1)); 113 ASSERT_EQ(0xFFFF0000u, action.GetBadgeTextColor(1));
114 ASSERT_EQ(0xFFFF0000u, action.GetBadgeTextColor(100)); 114 ASSERT_EQ(0xFFFF0000u, action.GetBadgeTextColor(100));
115 action.SetBadgeTextColor(100, 0xFF00FF00); 115 action.SetBadgeTextColor(100, 0xFF00FF00);
116 ASSERT_EQ(0xFFFF0000u, action.GetBadgeTextColor(1)); 116 ASSERT_EQ(0xFFFF0000u, action.GetBadgeTextColor(1));
117 ASSERT_EQ(0xFF00FF00u, action.GetBadgeTextColor(100)); 117 ASSERT_EQ(0xFF00FF00u, action.GetBadgeTextColor(100));
118 action.SetBadgeTextColor(ExtensionAction2::kDefaultTabId, 0xFF0000FFu); 118 action.SetBadgeTextColor(ExtensionAction::kDefaultTabId, 0xFF0000FFu);
119 ASSERT_EQ(0xFF0000FFu, action.GetBadgeTextColor(1)); 119 ASSERT_EQ(0xFF0000FFu, action.GetBadgeTextColor(1));
120 action.ClearAllValuesForTab(100); 120 action.ClearAllValuesForTab(100);
121 ASSERT_EQ(0xFF0000FFu, action.GetBadgeTextColor(100)); 121 ASSERT_EQ(0xFF0000FFu, action.GetBadgeTextColor(100));
122 122
123 // badge background color 123 // badge background color
124 ASSERT_EQ(0x00000000u, action.GetBadgeBackgroundColor(1)); 124 ASSERT_EQ(0x00000000u, action.GetBadgeBackgroundColor(1));
125 action.SetBadgeBackgroundColor(ExtensionAction2::kDefaultTabId, 125 action.SetBadgeBackgroundColor(ExtensionAction::kDefaultTabId,
126 0xFFFF0000u); 126 0xFFFF0000u);
127 ASSERT_EQ(0xFFFF0000u, action.GetBadgeBackgroundColor(1)); 127 ASSERT_EQ(0xFFFF0000u, action.GetBadgeBackgroundColor(1));
128 ASSERT_EQ(0xFFFF0000u, action.GetBadgeBackgroundColor(100)); 128 ASSERT_EQ(0xFFFF0000u, action.GetBadgeBackgroundColor(100));
129 action.SetBadgeBackgroundColor(100, 0xFF00FF00); 129 action.SetBadgeBackgroundColor(100, 0xFF00FF00);
130 ASSERT_EQ(0xFFFF0000u, action.GetBadgeBackgroundColor(1)); 130 ASSERT_EQ(0xFFFF0000u, action.GetBadgeBackgroundColor(1));
131 ASSERT_EQ(0xFF00FF00u, action.GetBadgeBackgroundColor(100)); 131 ASSERT_EQ(0xFF00FF00u, action.GetBadgeBackgroundColor(100));
132 action.SetBadgeBackgroundColor(ExtensionAction2::kDefaultTabId, 132 action.SetBadgeBackgroundColor(ExtensionAction::kDefaultTabId,
133 0xFF0000FFu); 133 0xFF0000FFu);
134 ASSERT_EQ(0xFF0000FFu, action.GetBadgeBackgroundColor(1)); 134 ASSERT_EQ(0xFF0000FFu, action.GetBadgeBackgroundColor(1));
135 action.ClearAllValuesForTab(100); 135 action.ClearAllValuesForTab(100);
136 ASSERT_EQ(0xFF0000FFu, action.GetBadgeBackgroundColor(100)); 136 ASSERT_EQ(0xFF0000FFu, action.GetBadgeBackgroundColor(100));
137 } 137 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_action2.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698