Issue 332024: Mark flaky tests as flaky:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332024: Mark flaky tests as flaky: (Closed)

Created:
11 years, 1 month ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Nicolas Sylvain, M-A Ruel, sky

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mark flaky tests as flaky: BookmarkHTMLWriterTest.Test (suspected resource flakiness) LoginPromptTest.TestTwoAuths TEST=none BUG=17592, 25794 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30087

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/bookmarks/bookmark_html_writer_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/login_prompt_uitest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

LGTM On Mon, Oct 26, 2009 at 7:07 AM, <mark@chromium.org> wrote: > LGTM > > ...

11 years, 1 month ago (2009-10-26 14:40:31 UTC) #4

sky

BookmarkHTMLWriterTest shouldn't be marked flakey. It will fail when the grd has changed but everything ...

11 years, 1 month ago (2009-10-26 20:46:29 UTC) #5

Paweł Hajdan Jr.

11 years, 1 month ago (2009-10-26 21:03:42 UTC) #6

On 2009/10/26 20:46:29, sky wrote:
> BookmarkHTMLWriterTest shouldn't be marked flakey. It will fail when the grd
has
> changed but everything hasn't been rebuilt.

I see. But I'd still rather make it as flaky, because the failures are flaky
(well, not because of the test, but this test is very prone to resources-related
flakiness).

IMHO the best option would be to get more attention to the resource flakiness
problem. It seems there is some thread on chromium-dev about that. I'm going to
respond there.

Expand Messages | Collapse Messages