Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 332024: Mark flaky tests as flaky: (Closed)

Created:
11 years, 1 month ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mark flaky tests as flaky: BookmarkHTMLWriterTest.Test (suspected resource flakiness) LoginPromptTest.TestTwoAuths TEST=none BUG=17592, 25794 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/login_prompt_uitest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
11 years, 1 month ago (2009-10-26 09:57:11 UTC) #1
M-A Ruel
lgtm
11 years, 1 month ago (2009-10-26 14:02:35 UTC) #2
Mark Mentovai
LGTM
11 years, 1 month ago (2009-10-26 14:07:17 UTC) #3
Nicolas Sylvain
LGTM On Mon, Oct 26, 2009 at 7:07 AM, <mark@chromium.org> wrote: > LGTM > > ...
11 years, 1 month ago (2009-10-26 14:40:31 UTC) #4
sky
BookmarkHTMLWriterTest shouldn't be marked flakey. It will fail when the grd has changed but everything ...
11 years, 1 month ago (2009-10-26 20:46:29 UTC) #5
Paweł Hajdan Jr.
11 years, 1 month ago (2009-10-26 21:03:42 UTC) #6
On 2009/10/26 20:46:29, sky wrote:
> BookmarkHTMLWriterTest shouldn't be marked flakey. It will fail when the grd
has
> changed but everything hasn't been rebuilt.

I see. But I'd still rather make it as flaky, because the failures are flaky
(well, not because of the test, but this test is very prone to resources-related
flakiness).

IMHO the best option would be to get more attention to the resource flakiness
problem. It seems there is some thread on chromium-dev about that. I'm going to
respond there.

Powered by Google App Engine
This is Rietveld 408576698