Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Side by Side Diff: chrome/browser/login_prompt_uitest.cc

Issue 332024: Mark flaky tests as flaky: (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "chrome/browser/net/url_fixer_upper.h" 7 #include "chrome/browser/net/url_fixer_upper.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 #include "chrome/common/url_constants.h" 9 #include "chrome/common/url_constants.h"
10 #include "chrome/test/automation/tab_proxy.h" 10 #include "chrome/test/automation/tab_proxy.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 99
100 NavigateTab(tab.get(), server->TestServerPageW(L"auth-digest")); 100 NavigateTab(tab.get(), server->TestServerPageW(L"auth-digest"));
101 101
102 EXPECT_TRUE(tab->NeedsAuth()); 102 EXPECT_TRUE(tab->NeedsAuth());
103 EXPECT_TRUE(tab->SetAuth(username_digest_, password_)); 103 EXPECT_TRUE(tab->SetAuth(username_digest_, password_));
104 EXPECT_EQ(ExpectedTitleFromAuth(username_digest_, password_), 104 EXPECT_EQ(ExpectedTitleFromAuth(username_digest_, password_),
105 GetActiveTabTitle()); 105 GetActiveTabTitle());
106 } 106 }
107 107
108 // Test that logging in on 2 tabs at once works. 108 // Test that logging in on 2 tabs at once works.
109 TEST_F(LoginPromptTest, TestTwoAuths) { 109 // Flaky, http://crbug.com/25794.
110 TEST_F(LoginPromptTest, FLAKY_TestTwoAuths) {
110 scoped_refptr<HTTPTestServer> server = 111 scoped_refptr<HTTPTestServer> server =
111 HTTPTestServer::CreateServer(kDocRoot, NULL); 112 HTTPTestServer::CreateServer(kDocRoot, NULL);
112 ASSERT_TRUE(NULL != server.get()); 113 ASSERT_TRUE(NULL != server.get());
113 114
114 scoped_refptr<TabProxy> basic_tab(GetActiveTabProxy()); 115 scoped_refptr<TabProxy> basic_tab(GetActiveTabProxy());
115 NavigateTab(basic_tab.get(), server->TestServerPageW(L"auth-basic")); 116 NavigateTab(basic_tab.get(), server->TestServerPageW(L"auth-basic"));
116 117
117 AppendTab(GURL(chrome::kAboutBlankURL)); 118 AppendTab(GURL(chrome::kAboutBlankURL));
118 scoped_refptr<TabProxy> digest_tab(GetActiveTabProxy()); 119 scoped_refptr<TabProxy> digest_tab(GetActiveTabProxy());
119 NavigateTab(digest_tab.get(), server->TestServerPageW(L"auth-digest")); 120 NavigateTab(digest_tab.get(), server->TestServerPageW(L"auth-digest"));
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 EXPECT_TRUE(tab->GoForward()); // should bring us to 'c' 166 EXPECT_TRUE(tab->GoForward()); // should bring us to 'c'
166 EXPECT_FALSE(tab->NeedsAuth()); 167 EXPECT_FALSE(tab->NeedsAuth());
167 168
168 // Now test that cancelling works as expected. 169 // Now test that cancelling works as expected.
169 NavigateTab(tab.get(), server->TestServerPageW(L"auth-basic")); 170 NavigateTab(tab.get(), server->TestServerPageW(L"auth-basic"));
170 EXPECT_TRUE(tab->NeedsAuth()); 171 EXPECT_TRUE(tab->NeedsAuth());
171 EXPECT_TRUE(tab->CancelAuth()); 172 EXPECT_TRUE(tab->CancelAuth());
172 EXPECT_FALSE(tab->NeedsAuth()); 173 EXPECT_FALSE(tab->NeedsAuth());
173 EXPECT_EQ(L"Denied: no auth", GetActiveTabTitle()); 174 EXPECT_EQ(L"Denied: no auth", GetActiveTabTitle());
174 } 175 }
OLDNEW
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698