Issue 3162038: Fire crash_service.exe on win slave during pyauto runs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3162038: Fire crash_service.exe on win slave during pyauto runs (Closed)

Created:
10 years, 4 months ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/buildbot/scripts/master/

Visibility:
Public.

Description

Fire crash_service.exe on win slave during pyauto runs BUG=53149 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57273

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	factory/chromium_commands.py	View		1 chunk	+7 lines, -3 lines	1 comment	Download
	M	factory/chromium_factory.py	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

10 years, 4 months ago (2010-08-25 00:56:55 UTC) #2

LGTM

http://codereview.chromium.org/3162038/diff/1/2
File factory/chromium_commands.py (right):

http://codereview.chromium.org/3162038/diff/1/2#newcode638
factory/chromium_commands.py:638: if not build_dir:
More pythonic:
build_dir = build_dir or self._build_dir
target = target or self._target

http://codereview.chromium.org/3162038/diff/1/3
File factory/chromium_factory.py (right):

http://codereview.chromium.org/3162038/diff/1/3#newcode507
factory/chromium_factory.py:507: if self._target_platform == 'win32':
Add comment explaining why you are doing this.

Expand Messages | Collapse Messages