factory/chromium_factory.py - Issue 3162038: Fire crash_service.exe on win slave during pyauto runs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: factory/chromium_factory.py

Issue 3162038: Fire crash_service.exe on win slave during pyauto runs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/buildbot/scripts/master/

Patch Set: Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 #!/usr/bin/python	1 #!/usr/bin/python

2 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.	2 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 """Utility class to build the chromium master BuildFactory's.	6 """Utility class to build the chromium master BuildFactory's.

7	7

8 Based on gclient_factory.py and adds chromium-specific steps."""	8 Based on gclient_factory.py and adds chromium-specific steps."""

9	9

10 import os	10 import os

(...skipping 485 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
496 # lines (e.g. everything from here on other than	496 # lines (e.g. everything from here on other than

497 # AddDownloadAndExtractOfficialBuild()).	497 # AddDownloadAndExtractOfficialBuild()).

498 factory = self.BuildFactory(identifier, target, clobber, tests, mode,	498 factory = self.BuildFactory(identifier, target, clobber, tests, mode,

499 slave_type, options, compile_timeout, build_url,	499 slave_type, options, compile_timeout, build_url,

500 project, factory_properties)	500 project, factory_properties)

501 chromium_cmd_obj = chromium_commands.ChromiumCommands(factory, identifier,	501 chromium_cmd_obj = chromium_commands.ChromiumCommands(factory, identifier,

502 target,	502 target,

503 self._build_dir,	503 self._build_dir,

504 self._target_platform)	504 self._target_platform)

505 chromium_cmd_obj.AddDownloadAndExtractOfficialBuild(identifier)	505 chromium_cmd_obj.AddDownloadAndExtractOfficialBuild(identifier)

	506

	507 if self._target_platform == 'win32':
	John Grabowski 2010/08/25 00:56:55 Add comment explaining why you are doing this. Add comment explaining why you are doing this.
	508 chromium_cmd_obj.AddRunCrashHandler(build_dir='chrome-win32', target='.')

506 self._AddTests(chromium_cmd_obj, tests, mode, factory_properties)	509 self._AddTests(chromium_cmd_obj, tests, mode, factory_properties)

507 return factory	510 return factory

OLD	NEW

« factory/chromium_commands.py ('K') | « factory/chromium_commands.py ('k') | no next file » | no next file with comments »