Chromium Code Reviews| Index: factory/chromium_commands.py |
| =================================================================== |
| --- factory/chromium_commands.py (revision 56990) |
| +++ factory/chromium_commands.py (working copy) |
| @@ -634,10 +634,14 @@ |
| link_text='layout test results', |
| command=cmd) |
| - def AddRunCrashHandler(self): |
| + def AddRunCrashHandler(self, build_dir=None, target=None): |
| + if not build_dir: |
|
John Grabowski
2010/08/25 00:56:55
More pythonic:
build_dir = build_dir or self._buil
|
| + build_dir = self._build_dir |
| + if not target: |
| + target = self._target |
| cmd = [self._python, self._crash_handler_tool, |
| - '--build-dir', self._build_dir, |
| - '--target', self._target] |
| + '--build-dir', build_dir, |
| + '--target', target] |
| self.AddTestStep(shell.ShellCommand, 'Start Crash Handler', cmd) |
| def AddProcessDumps(self): |