Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: factory/chromium_commands.py

Issue 3162038: Fire crash_service.exe on win slave during pyauto runs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/buildbot/scripts/master/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | factory/chromium_factory.py » ('j') | factory/chromium_factory.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: factory/chromium_commands.py
===================================================================
--- factory/chromium_commands.py (revision 56990)
+++ factory/chromium_commands.py (working copy)
@@ -634,10 +634,14 @@
link_text='layout test results',
command=cmd)
- def AddRunCrashHandler(self):
+ def AddRunCrashHandler(self, build_dir=None, target=None):
+ if not build_dir:
John Grabowski 2010/08/25 00:56:55 More pythonic: build_dir = build_dir or self._buil
+ build_dir = self._build_dir
+ if not target:
+ target = self._target
cmd = [self._python, self._crash_handler_tool,
- '--build-dir', self._build_dir,
- '--target', self._target]
+ '--build-dir', build_dir,
+ '--target', target]
self.AddTestStep(shell.ShellCommand, 'Start Crash Handler', cmd)
def AddProcessDumps(self):
« no previous file with comments | « no previous file | factory/chromium_factory.py » ('j') | factory/chromium_factory.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698