Fire crash_service.exe on win slave during pyauto runs

factory/chromium_commands.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Set of utilities to add commands to a buildbot factory.
 
 This is based on commands.py and adds chromium-specific commands."""
 
 import logging
@@ skipping 616 matching lines @@
              '--build-dir', self._build_dir,
              '--build-number', WithProperties("%(buildnumber)s"),
              '--builder-name', WithProperties("%(buildername)s"),]
 
       self.AddArchiveStep(
           data_description='webkit_tests results',
           base_url=url,
           link_text='layout test results',
           command=cmd)
 
-  def AddRunCrashHandler(self):
+  def AddRunCrashHandler(self, build_dir=None, target=None):
+    if not build_dir:

[John Grabowski, 2010/08/25 00:56:55]

More pythonic:
build_dir = build_dir or self._build_dir
target = target or self._target

+      build_dir = self._build_dir
+    if not target:
+      target = self._target
     cmd = [self._python, self._crash_handler_tool,
-           '--build-dir', self._build_dir,
-           '--target', self._target]
+           '--build-dir', build_dir,
+           '--target', target]
     self.AddTestStep(shell.ShellCommand, 'Start Crash Handler', cmd)
 
   def AddProcessDumps(self):
     cmd = [self._python, self._process_dumps_tool,
            '--build-dir', self._build_dir,
            '--target', self._target]
     self.AddTestStep(shell.ShellCommand, 'Process Dumps', cmd)
 
   def AddRunCoverageBundles(self, factory_properties=None):
     # If updating this command, update the mirror of it in chrome_tests.gypi.
@@ skipping 54 matching lines @@
     cmd = [self._python, self._download_and_extract_official_tool,
            '--identifier', identifier,
            # TODO(jrg): for now we are triggered on a timer and always
            # use the latest build.  Instead we should trigger on the
            # presence of new build and pass that info down for a
            # --build N arg.
            '--latest']
     self.AddTestStep(commands.WaterfallLoggingShellCommand,
                      'Download and extract official build', cmd,
                      halt_on_failure=True)