Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: factory/chromium_commands.py

Issue 3162038: Fire crash_service.exe on win slave during pyauto runs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/buildbot/scripts/master/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | factory/chromium_factory.py » ('j') | factory/chromium_factory.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Set of utilities to add commands to a buildbot factory. 6 """Set of utilities to add commands to a buildbot factory.
7 7
8 This is based on commands.py and adds chromium-specific commands.""" 8 This is based on commands.py and adds chromium-specific commands."""
9 9
10 import logging 10 import logging
(...skipping 616 matching lines...) Expand 10 before | Expand all | Expand 10 after
627 '--build-dir', self._build_dir, 627 '--build-dir', self._build_dir,
628 '--build-number', WithProperties("%(buildnumber)s"), 628 '--build-number', WithProperties("%(buildnumber)s"),
629 '--builder-name', WithProperties("%(buildername)s"),] 629 '--builder-name', WithProperties("%(buildername)s"),]
630 630
631 self.AddArchiveStep( 631 self.AddArchiveStep(
632 data_description='webkit_tests results', 632 data_description='webkit_tests results',
633 base_url=url, 633 base_url=url,
634 link_text='layout test results', 634 link_text='layout test results',
635 command=cmd) 635 command=cmd)
636 636
637 def AddRunCrashHandler(self): 637 def AddRunCrashHandler(self, build_dir=None, target=None):
638 if not build_dir:
John Grabowski 2010/08/25 00:56:55 More pythonic: build_dir = build_dir or self._buil
639 build_dir = self._build_dir
640 if not target:
641 target = self._target
638 cmd = [self._python, self._crash_handler_tool, 642 cmd = [self._python, self._crash_handler_tool,
639 '--build-dir', self._build_dir, 643 '--build-dir', build_dir,
640 '--target', self._target] 644 '--target', target]
641 self.AddTestStep(shell.ShellCommand, 'Start Crash Handler', cmd) 645 self.AddTestStep(shell.ShellCommand, 'Start Crash Handler', cmd)
642 646
643 def AddProcessDumps(self): 647 def AddProcessDumps(self):
644 cmd = [self._python, self._process_dumps_tool, 648 cmd = [self._python, self._process_dumps_tool,
645 '--build-dir', self._build_dir, 649 '--build-dir', self._build_dir,
646 '--target', self._target] 650 '--target', self._target]
647 self.AddTestStep(shell.ShellCommand, 'Process Dumps', cmd) 651 self.AddTestStep(shell.ShellCommand, 'Process Dumps', cmd)
648 652
649 def AddRunCoverageBundles(self, factory_properties=None): 653 def AddRunCoverageBundles(self, factory_properties=None):
650 # If updating this command, update the mirror of it in chrome_tests.gypi. 654 # If updating this command, update the mirror of it in chrome_tests.gypi.
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 cmd = [self._python, self._download_and_extract_official_tool, 709 cmd = [self._python, self._download_and_extract_official_tool,
706 '--identifier', identifier, 710 '--identifier', identifier,
707 # TODO(jrg): for now we are triggered on a timer and always 711 # TODO(jrg): for now we are triggered on a timer and always
708 # use the latest build. Instead we should trigger on the 712 # use the latest build. Instead we should trigger on the
709 # presence of new build and pass that info down for a 713 # presence of new build and pass that info down for a
710 # --build N arg. 714 # --build N arg.
711 '--latest'] 715 '--latest']
712 self.AddTestStep(commands.WaterfallLoggingShellCommand, 716 self.AddTestStep(commands.WaterfallLoggingShellCommand,
713 'Download and extract official build', cmd, 717 'Download and extract official build', cmd,
714 halt_on_failure=True) 718 halt_on_failure=True)
OLDNEW
« no previous file with comments | « no previous file | factory/chromium_factory.py » ('j') | factory/chromium_factory.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698