Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 3146029: Cleanup: rename ProxyRules::socks_proxy --> ProxyRules::fallback_proxy.... (Closed)

Created:
10 years, 4 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, John Grabowski, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Cleanup: rename ProxyRules::socks_proxy --> ProxyRules::fallback_proxy. BUG=None TEST=Compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57294

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : add missing unittest file #

Patch Set 7 : sync and include a new chromeos file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -39 lines) Patch
M chrome/browser/chromeos/proxy_config_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_proxy_settings.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_proxy_settings_unittest.cc View 6 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config.h View 1 2 3 4 5 6 2 chunks +6 lines, -8 lines 0 comments Download
M net/proxy/proxy_config.cc View 1 2 3 4 5 6 6 chunks +27 lines, -17 lines 0 comments Download
M net/proxy/proxy_config_service_common_unittest.h View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M net/proxy/proxy_config_service_common_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_mac.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_unittest.cc View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eroman
misc cleanup, as it was causing confusion to someone else implementing a proxyconfigservice.
10 years, 4 months ago (2010-08-20 22:04:32 UTC) #1
rvargas (doing something else)
10 years, 4 months ago (2010-08-21 02:55:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698