Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Side by Side Diff: chrome/browser/chromeos/proxy_config_service_impl.cc

Issue 3146029: Cleanup: rename ProxyRules::socks_proxy --> ProxyRules::fallback_proxy.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync and include a new chromeos file Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/importer/firefox_proxy_settings.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/proxy_config_service_impl.h" 5 #include "chrome/browser/chromeos/proxy_config_service_impl.h"
6 6
7 #include <ostream> 7 #include <ostream>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 net_config->proxy_rules().single_proxy = single_proxy.server; 122 net_config->proxy_rules().single_proxy = single_proxy.server;
123 net_config->proxy_rules().bypass_rules = bypass_rules; 123 net_config->proxy_rules().bypass_rules = bypass_rules;
124 break; 124 break;
125 case MODE_PROXY_PER_SCHEME: 125 case MODE_PROXY_PER_SCHEME:
126 *net_config = net::ProxyConfig(); 126 *net_config = net::ProxyConfig();
127 net_config->proxy_rules().type = 127 net_config->proxy_rules().type =
128 net::ProxyConfig::ProxyRules::TYPE_PROXY_PER_SCHEME; 128 net::ProxyConfig::ProxyRules::TYPE_PROXY_PER_SCHEME;
129 net_config->proxy_rules().proxy_for_http = http_proxy.server; 129 net_config->proxy_rules().proxy_for_http = http_proxy.server;
130 net_config->proxy_rules().proxy_for_https = https_proxy.server; 130 net_config->proxy_rules().proxy_for_https = https_proxy.server;
131 net_config->proxy_rules().proxy_for_ftp = ftp_proxy.server; 131 net_config->proxy_rules().proxy_for_ftp = ftp_proxy.server;
132 net_config->proxy_rules().socks_proxy = socks_proxy.server; 132 net_config->proxy_rules().fallback_proxy = socks_proxy.server;
133 net_config->proxy_rules().bypass_rules = bypass_rules; 133 net_config->proxy_rules().bypass_rules = bypass_rules;
134 break; 134 break;
135 default: 135 default:
136 NOTREACHED() << "Unrecognized proxy config mode"; 136 NOTREACHED() << "Unrecognized proxy config mode";
137 break; 137 break;
138 } 138 }
139 } 139 }
140 140
141 std::string ProxyConfigServiceImpl::ProxyConfig::ToString() const { 141 std::string ProxyConfigServiceImpl::ProxyConfig::ToString() const {
142 return ProxyConfigToString(*this); 142 return ProxyConfigToString(*this);
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 LOG(INFO) << "Proxy configuration changed"; 296 LOG(INFO) << "Proxy configuration changed";
297 cached_config_ = new_config; 297 cached_config_ = new_config;
298 // Notify observers of new proxy config. 298 // Notify observers of new proxy config.
299 net::ProxyConfig net_config; 299 net::ProxyConfig net_config;
300 cached_config_.ConvertToNetProxyConfig(&net_config); 300 cached_config_.ConvertToNetProxyConfig(&net_config);
301 FOR_EACH_OBSERVER(net::ProxyConfigService::Observer, observers_, 301 FOR_EACH_OBSERVER(net::ProxyConfigService::Observer, observers_,
302 OnProxyConfigChanged(net_config)); 302 OnProxyConfigChanged(net_config));
303 } 303 }
304 304
305 } // namespace chromeos 305 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/importer/firefox_proxy_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698