Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: net/proxy/proxy_config.h

Issue 3146029: Cleanup: rename ProxyRules::socks_proxy --> ProxyRules::fallback_proxy.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync and include a new chromeos file Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/importer/firefox_proxy_settings_unittest.cc ('k') | net/proxy/proxy_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_config.h
===================================================================
--- net/proxy/proxy_config.h (revision 57274)
+++ net/proxy/proxy_config.h (working copy)
@@ -70,9 +70,7 @@
void ParseFromString(const std::string& proxy_rules);
// Returns one of {&proxy_for_http, &proxy_for_https, &proxy_for_ftp,
- // &socks_proxy}, or NULL if it is a scheme that we don't have a mapping
- // for. If the scheme mapping is not present and socks_proxy is defined,
- // we fall back to using socks_proxy.
+ // &fallback_proxy}, or NULL if there is no proxy to use.
// Should only call this if the type is TYPE_PROXY_PER_SCHEME.
const ProxyServer* MapUrlSchemeToProxy(const std::string& url_scheme) const;
@@ -95,14 +93,14 @@
ProxyServer proxy_for_https;
ProxyServer proxy_for_ftp;
- // Set if the configuration has a SOCKS proxy fallback.
- ProxyServer socks_proxy;
+ // Used when there isn't a more specific per-scheme proxy server.
+ ProxyServer fallback_proxy;
private:
- // Returns one of {&proxy_for_http, &proxy_for_https, &proxy_for_ftp,
- // &socks_proxy}, or NULL if it is a scheme that we don't have a mapping
+ // Returns one of {&proxy_for_http, &proxy_for_https, &proxy_for_ftp}
+ // or NULL if it is a scheme that we don't have a mapping
// for. Should only call this if the type is TYPE_PROXY_PER_SCHEME.
- ProxyServer* MapSchemeToProxy(const std::string& scheme);
+ ProxyServer* MapUrlSchemeToProxyNoFallback(const std::string& scheme);
};
typedef int ID;
« no previous file with comments | « chrome/browser/importer/firefox_proxy_settings_unittest.cc ('k') | net/proxy/proxy_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698