net/proxy/proxy_config_service_common_unittest.cc - Issue 3146029: Cleanup: rename ProxyRules::socks_proxy --> ProxyRules::fallback_proxy....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_config_service_common_unittest.cc

Issue 3146029: Cleanup: rename ProxyRules::socks_proxy --> ProxyRules::fallback_proxy.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: sync and include a new chromeos file Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_config_service_common_unittest.cc

===================================================================

--- net/proxy/proxy_config_service_common_unittest.cc (revision 57274)

+++ net/proxy/proxy_config_service_common_unittest.cc (working copy)

@@ -66,8 +66,8 @@

rules.proxy_for_http, &failure_details, &failed);

MatchesProxyServerHelper("Bad proxy_for_https", proxy_for_https,

rules.proxy_for_https, &failure_details, &failed);

- MatchesProxyServerHelper("Bad proxy_for_socks", socks_proxy,

- rules.socks_proxy, &failure_details, &failed);

+ MatchesProxyServerHelper("Bad fallback_proxy", fallback_proxy,

+ rules.fallback_proxy, &failure_details, &failed);

std::string actual_flattened_bypass = FlattenProxyBypass(rules.bypass_rules);

if (std::string(flattened_bypass_rules) != actual_flattened_bypass) {