Issue 3140023: Make codereview.setting syntax more liberal and add more unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3140023: Make codereview.setting syntax more liberal and add more unit tests. (Closed)

Created:
10 years, 4 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Make codereview.setting syntax more liberal and add more unit tests. Improve gclient_utils to test output lacking trailing LF BUG=none TEST=new unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57047

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -18 lines)			Patch
M	gcl.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/gcl_unittest.py	View	2 chunks	+36 lines, -0 lines	0 comments	Download
M	tests/gclient_utils_test.py	View	2 chunks	+25 lines, -16 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM