Make codereview.setting syntax more liberal and add more unit tests.

tests/gcl_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for gcl.py."""
 
 # Fixes include path.
 from super_mox import mox, SuperMoxTestBase
 
@@ skipping 10 matching lines @@
     self.mox.StubOutWithMock(gcl.SVN, 'GetCheckoutRoot')
     self.mox.StubOutWithMock(gcl, 'tempfile')
     self.mox.StubOutWithMock(gcl.upload, 'RealMain')
     self.mox.StubOutWithMock(gcl.gclient_utils, 'FileRead')
     self.mox.StubOutWithMock(gcl.gclient_utils, 'FileWrite')
     gcl.REPOSITORY_ROOT = None
 
 
 class GclUnittest(GclTestsBase):
   """General gcl.py tests."""
+  def tearDown(self):
+    gcl.CODEREVIEW_SETTINGS = {}
+
   def testMembersChanged(self):
     self.mox.ReplayAll()
     members = [
         'CODEREVIEW_SETTINGS', 'CODEREVIEW_SETTINGS_FILE',
         'CODEREVIEW_SETTINGS_FILE_NOT_FOUND',
         'CMDchange', 'CMDchanges', 'CMDcommit', 'CMDdelete', 'CMDdeleteempties',
         'CMDdescription', 'CMDdiff', 'CMDhelp', 'CMDlint', 'CMDnothave',
         'CMDopened', 'CMDpassthru', 'CMDpresubmit', 'CMDrename', 'CMDsettings',
         'CMDstatus', 'CMDtry', 'CMDupload',
         'ChangeInfo', 'Command', 'DEFAULT_LINT_IGNORE_REGEX',
@@ skipping 25 matching lines @@
     pass
 
   def testUnknownFiles(self):
     # TODO(maruel): TEST ME
     pass
 
   def testCheckHomeForFile(self):
     # TODO(maruel): TEST ME
     pass
 
+  def testDefaultSettings(self):
+    self.assertEquals({}, gcl.CODEREVIEW_SETTINGS)
+
+  def testGetCodeReviewSettingOk(self):
+    self.mox.StubOutWithMock(gcl, 'GetCachedFile')
+    gcl.GetCachedFile(gcl.CODEREVIEW_SETTINGS_FILE).AndReturn(
+        'foo:bar\n'
+        '# comment\n'
+        ' c : d \n\r'
+        'e: f')
+    self.mox.ReplayAll()
+    self.assertEquals('bar', gcl.GetCodeReviewSetting('foo'))
+    self.assertEquals('d', gcl.GetCodeReviewSetting('c'))
+    self.assertEquals('f', gcl.GetCodeReviewSetting('e'))
+    self.assertEquals('', gcl.GetCodeReviewSetting('other'))
+    self.assertEquals(
+        {'foo': 'bar', 'c': 'd', 'e': 'f', '__just_initialized': None},
+        gcl.CODEREVIEW_SETTINGS)
+
+  def testGetCodeReviewSettingFail(self):
+    self.mox.StubOutWithMock(gcl, 'GetCachedFile')
+    gcl.GetCachedFile(gcl.CODEREVIEW_SETTINGS_FILE).AndReturn(
+        'aaa\n'
+        ' c : d \n\r'
+        'e: f')
+    self.mox.ReplayAll()
+    try:
+      gcl.GetCodeReviewSetting('c')
+      self.fail()
+    except gcl.gclient_utils.Error:
+      pass
+    self.assertEquals({}, gcl.CODEREVIEW_SETTINGS)
+
   def testGetRepositoryRootNone(self):
     gcl.os.getcwd().AndReturn(self.fake_root_dir)
     gcl.SVN.GetCheckoutRoot(self.fake_root_dir).AndReturn(None)
     self.mox.ReplayAll()
     self.assertRaises(gcl.gclient_utils.Error, gcl.GetRepositoryRoot)
 
   def testGetRepositoryRootGood(self):
     root_path = gcl.os.path.join('bleh', 'prout', 'pouet')
     gcl.os.getcwd().AndReturn(root_path)
     gcl.SVN.GetCheckoutRoot(root_path).AndReturn(root_path + '.~')
@@ skipping 200 matching lines @@
     self.mox.ReplayAll()
 
     gcl.CMDupload(['naame', '--no_watchlists'])
     self.assertEquals(change_info.issue, 1)
     self.assertEquals(change_info.patchset, 2)
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()